652989 - Enable chrome methodjit in Fennec by default

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Bug 646312 turned on javascript.options.methodjit.chrome by default for desktop Firefox, but it is still disabled in Fennec.  This patch enables it by default in Fennec.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 528466 [details] [diff] [review]
patch

What about the other pref?

 pref("javascript.options.jitprofiling.content", true);
-pref("javascript.options.jitprofiling.chrome",  false);
+pref("javascript.options.jitprofiling.chrome",  true);

Comment 2

[Matt Brubeck (:mbrubeck)]

We don't override javascript.options.jitprofiling.chrome in Fennec, so we do not need to make any changes to enable it.

If we decide to keep methodjit.chrome disabled in Fennec, we might want to add an override to disable jitprofiling.chrome also.  (I don't know whether that's important or not - does that pref have any effect if methodjit.chrome is false?)

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 528466 [details] [diff] [review]
patch

Watch Ts when this lands

Comment 4

[Shane Bundy]

http://hg.mozilla.org/mozilla-central/rev/08af49227091

Comment 5

[Tony Chung [:tchung]]

Verified fix on Mozilla/5.0 (Android; Linux armv71; rv:6.0a1) Gecko/20110505 Firefox/6.0a1 Fennec/6.0a1.  
 
Nexus S: Test harness addon reports Ts time reports 4863ms.
Motorola Xoom: Test harness addon reports Ts time reports 4156ms.