Closed Bug 652989 Opened 11 years ago Closed 11 years ago

Enable chrome methodjit in Fennec by default

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 6

People

(Reporter: mbrubeck, Assigned: mbrubeck)

References

Details

(Keywords: mobile, perf)

Attachments

(1 file)

Attached patch patchSplinter Review
Bug 646312 turned on javascript.options.methodjit.chrome by default for desktop Firefox, but it is still disabled in Fennec.  This patch enables it by default in Fennec.
Attachment #528466 - Flags: review?(mark.finkle)
Comment on attachment 528466 [details] [diff] [review]
patch

What about the other pref?

 pref("javascript.options.jitprofiling.content", true);
-pref("javascript.options.jitprofiling.chrome",  false);
+pref("javascript.options.jitprofiling.chrome",  true);
We don't override javascript.options.jitprofiling.chrome in Fennec, so we do not need to make any changes to enable it.

If we decide to keep methodjit.chrome disabled in Fennec, we might want to add an override to disable jitprofiling.chrome also.  (I don't know whether that's important or not - does that pref have any effect if methodjit.chrome is false?)
Comment on attachment 528466 [details] [diff] [review]
patch

Watch Ts when this lands
Attachment #528466 - Flags: review?(mark.finkle) → review+
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [has patch]
Target Milestone: --- → Firefox 6
Verified fix on Mozilla/5.0 (Android; Linux armv71; rv:6.0a1) Gecko/20110505 Firefox/6.0a1 Fennec/6.0a1.  
 
Nexus S: Test harness addon reports Ts time reports 4863ms.
Motorola Xoom: Test harness addon reports Ts time reports 4156ms.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.