Closed Bug 653061 Opened 9 years ago Closed 9 years ago

too much security mail after BMO upgrade

Categories

(bugzilla.mozilla.org :: General, defect)

Production
x86
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: dveditz, Assigned: glob)

References

Details

Attachments

(1 file)

The security list was set up to receive mail when bugs were added to or removed from the core-security group (bugspam was also sent for a few other things like dependency changes; was never sure if that was intentional or if it was based on the "or any other change" mail setting).

After the 4.0 upgrade the security alias is receiving bugmail for what looks like every change to any bug in the core-security group -- quite a bit more mail. This is drowning out the important functionality of alerting us to new (and removed) security bugs.
We also discovered earlier today that it's failing to send mail when the group is removed from a bug.  So it appears that it's only sending mail when the group is set (and always sending it when it's set) instead of only sending it on the add/remove actions.
Assignee: nobody → glob
Attached patch patch β€” β€” Splinter Review
the problem is when you just make a comment on a bug, the @$diffs array is empty.  this was incorrectly being detected as a new bug, resulting in excessive bugmail.

the only real way we have to detect new bugs in this hook is to count the comments, which is what this fix does.
Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bmo/4.0/
modified extensions/BMO/Extension.pm
Committed revision 7655.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Depends on: 654921
You need to log in before you can comment on or make changes to this bug.