Rename Workspace to Scratchpad

VERIFIED FIXED in Firefox 6

Status

()

Firefox
Developer Tools
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: rc, Assigned: rc)

Tracking

unspecified
Firefox 6
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox6-)

Details

(Whiteboard: [workspace][scratchpad][fixed-in-devtools][merged-to-mozilla-central])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
After landing the Integrate Workspace bug 642176, some concerns about the name of the feature arose during the l10n review.

The feature is intended to provide a simple text editor for creating and evaluating bits of JavaScript code for the purposes of function prototyping, experimentation and convenient scripting.

Discussion occurred here:

https://groups.google.com/forum/#!topic/mozilla.dev.l10n/eYZU4uaLOrQ

and here (cross-posted):

https://groups.google.com/forum/#!topic/mozilla.dev.apps.firefox/eYZU4uaLOrQ

I think the currently-preferred name is Scratchpad. I'm leaning towards leaving off "JavaScript" from that name because we will likely add additional, non JS capabilities in the future.

Other suggestions have been:

JavaScript Environment
Scrapbook
Notepad
Editor

(all of which could have JS pre-pended to them)

We should provide a solid description of this feature in the localization note in browser.dtd with a reference to this bug.

Note to localizers:

It's quite possible that you won't have a good analogue for the word "Scratchpad" in your locale. You should feel free to find a close approximation to it or choose a word that means "simple discardable text editor".
(Assignee)

Updated

6 years ago
Assignee: nobody → rcampbell
(Assignee)

Updated

6 years ago
Depends on: 642176
(In reply to comment #0)
> I'm leaning towards leaving
> off "JavaScript" from that name because we will likely add additional, non JS
> capabilities in the future.

In which case you can rename the item. However, even then, my objection would remain that the Tools menu isn't a developer menu and "Scratchpad" seems generic enough to confuse non-developers.
(Assignee)

Comment 2

6 years ago
(In reply to comment #1)
> (In reply to comment #0)
> > I'm leaning towards leaving
> > off "JavaScript" from that name because we will likely add additional, non JS
> > capabilities in the future.
> 
> In which case you can rename the item. However, even then, my objection would
> remain that the Tools menu isn't a developer menu and "Scratchpad" seems
> generic enough to confuse non-developers.

Confuse them by having a menu item that opens a window? I don't understand.

A non-developer opens Firefox. He opens the Tools menu, sees "Scratchpad" for the first time. The non-developer (whom I will call Bill for the purposes of this story who is really excellent at racquet-ball and has a keen interest in non-euclidian geometry) selects Scratchpad from the menu and opens a window. Bill sees a text editor on his screen. Types a bit in it. Closes window thinking, "gee, that's nice. Now I have a place to write some math equations when I think of them."

Bill is not confused.

Web Developer or not, I don't think the Scratchpad is going to be out-of-place in the Tools menu.
Chances are that Bill already has a place to write some math equations. What makes you believe we can and should deliver a better tool for that use case with stock Firefox? Besides obvious feature creep concerns, it seems like this might hinder future developments for this from a dev tools perspective, since you don't want to confuse Bill going forward either.

Also, for the Firefox button you're actually going to put it in the web developer menu, right?
(Assignee)

Comment 4

6 years ago
(In reply to comment #3)
> Chances are that Bill already has a place to write some math equations. What
> makes you believe we can and should deliver a better tool for that use case
> with stock Firefox? Besides obvious feature creep concerns, it seems like this
> might hinder future developments for this from a dev tools perspective, since
> you don't want to confuse Bill going forward either.

I'm not saying Bill (or anyone else) should use the Scratchpad as their default editor, but it's there if they want it. Bill very probably has another editor he uses for his own purposes.

I'm not sure I understand your resistance to this living in the Tools menu. It is a Tool. When we have more web developery menu items, we can add a Web Developer sub-menu and move it there. Should we block the release of this tool for another submenu on one platform?

> Also, for the Firefox button you're actually going to put it in the web
> developer menu, right?

Yes.
(In reply to comment #4)
> I'm not saying Bill (or anyone else) should use the Scratchpad as their default
> editor, but it's there if they want it.

This doesn't sound like the right criteria for exposing features to users.

> Should we block the release of this tool for another submenu on one platform?

Either that or let the label be clear about this being a developer tool. (The Tools menu exists on all platforms, but it's not visible by default on Windows Vista and 7.)

> > Also, for the Firefox button you're actually going to put it in the web
> > developer menu, right?
> 
> Yes.

So this would be inconsistent. If we want a generic scratchpad, we need to make it consistently discoverable across platforms. If we don't want a generic scratchpad, we shouldn't accidentally expose it as such to some users.
(Assignee)

Comment 6

6 years ago
Created attachment 528684 [details] [diff] [review]
rename workspace to scratchpad

patch to rename Workspace to Scratchpad. Should be comprehensive. Should have all Workspace and ws* variables and identifiers as well.
Attachment #528684 - Flags: review?(community)
(Assignee)

Updated

6 years ago
Whiteboard: [workspace] → [workspace][scratchpad]
Comment on attachment 528684 [details] [diff] [review]
rename workspace to scratchpad

See comment 5.
Attachment #528684 - Flags: review-
(Assignee)

Comment 8

6 years ago
created bug 653221 to add a Web Developer sub menu to the Tools menu.
(Assignee)

Comment 9

6 years ago
Dao: Could you at least wait until I'm finished filing bugs before r-'ing my patch?
(Assignee)

Updated

6 years ago
Blocks: 653221
Comment on attachment 528684 [details] [diff] [review]
rename workspace to scratchpad

I had no idea that there was something to wait for. You could have revealed your plan when or before attaching your patch...

Revoking my r- for bug 653221, but it's not ideal that no browser peer ever reviewed the entry points in the browser UI at least.
Attachment #528684 - Flags: review-
(Assignee)

Comment 11

6 years ago
(In reply to comment #10)
> Comment on attachment 528684 [details] [diff] [review]
> rename workspace to scratchpad
> 
> I had no idea that there was something to wait for. You could have revealed
> your plan when or before attaching your patch...

I figured I'd have the follow-up bug filed and the patch written before anybody got around to reviewing that. Was just discussing it with my team.

> Revoking my r- for bug 653221, but it's not ideal that no browser peer ever
> reviewed the entry points in the browser UI at least.

Thanks. I've asked for your review in bug 653221.
(In reply to comment #10)
> I had no idea that there was something to wait for. You could have revealed
> your plan when or before attaching your patch...
...or you could have waited more than four minutes before jumping all over it.  

> Revoking my r- for bug 653221, but it's not ideal that no browser peer ever
> reviewed the entry points in the browser UI at least.
Hi.  Despite not being listed in the wiki yet, I've got this lovely e-mail from shaver bestowing the powers of a browser peer onto me.  So yes, it did get looked at by a browser peer, and at the time I felt that Scratchpad was fine to put under the tools menu.  After l10n feedback and this name change, placing it under Web Developer certainly feels like the better solution.
(In reply to comment #12)
> (In reply to comment #10)
> > I had no idea that there was something to wait for. You could have revealed
> > your plan when or before attaching your patch...
> ...or you could have waited more than four minutes before jumping all over it.

I felt that jumping all over it was the right reaction to the lack of a response other than a patch apparently ignoring my concerns entirely.

Comment 14

6 years ago
We can haz input from the UX Team?
Keywords: ux-jargon
(Assignee)

Comment 15

6 years ago
(In reply to comment #14)
> We can haz input from the UX Team?

for the rename of Workspace to Scratchpad?

Please don't conflate this bug with the Web Developer menu bug 653221.
This has been discussed to death in the newsgroups.  We don't need UX input on this.
Keywords: ux-jargon

Comment 17

6 years ago
Comment on attachment 528684 [details] [diff] [review]
rename workspace to scratchpad

>diff --git a/browser/locales/en-US/chrome/browser/browser.dtd b/browser/locales/en-US/chrome/browser/browser.dtd

>+<!ENTITY scratchpad.label             "Scratchpad">
>+<!ENTITY scratchpad.accesskey         "O">

We need another letter here. R and T are not used, as far as I know.

Or we could use S if the item moves to a Web Developer sub-menu.
(Assignee)

Comment 18

6 years ago
(In reply to comment #17)
> Comment on attachment 528684 [details] [diff] [review] [review]
> rename workspace to scratchpad
> 
> >diff --git a/browser/locales/en-US/chrome/browser/browser.dtd b/browser/locales/en-US/chrome/browser/browser.dtd
> 
> >+<!ENTITY scratchpad.label             "Scratchpad">
> >+<!ENTITY scratchpad.accesskey         "O">
> 
> We need another letter here. R and T are not used, as far as I know.
> 
> Or we could use S if the item moves to a Web Developer sub-menu.

Right. Good catch. I'll flip that over to an R for now and we can move it to the S when the Web Developer sub-menu gets decided.

Thanks for the comment!
(Assignee)

Comment 19

6 years ago
Created attachment 529549 [details] [diff] [review]
[checked-in] rename workspace to scratchpad 2

updated access key to "r" per Hasse's comment.
Attachment #528684 - Attachment is obsolete: true
Attachment #528684 - Flags: review?(community)
Attachment #529549 - Flags: review?(community)
(Assignee)

Updated

6 years ago
Attachment #529549 - Flags: review?(community) → review?(l10n)
(Assignee)

Updated

6 years ago
Blocks: 653934
(Assignee)

Comment 20

6 years ago
ping for review? This is holding us back from merging.
(Assignee)

Updated

6 years ago
Whiteboard: [workspace][scratchpad] → [workspace][scratchpad][waiting-for-review]
What part needs review? The whole patch or just the l10n bits?
(Assignee)

Comment 22

6 years ago
just the l10n bits, though feel free to take a pass through it if you'd like to checkout some of the renaming I did in here. The patch ended up being quite large.
(Assignee)

Updated

6 years ago
Status: NEW → ASSIGNED

Comment 23

6 years ago
Comment on attachment 529549 [details] [diff] [review]
[checked-in] rename workspace to scratchpad 2

r+ on the localization notes for the most part. Didn't look into the patch itself at depth. I've just got more echos in favor of the developer submenu (bug 653221), so I'll chime in there.
Attachment #529549 - Flags: review?(l10n) → review+
(Assignee)

Updated

6 years ago
Whiteboard: [workspace][scratchpad][waiting-for-review] → [workspace][scratchpad][fixed-in-devtools]
(Assignee)

Comment 24

6 years ago
Comment on attachment 529549 [details] [diff] [review]
[checked-in] rename workspace to scratchpad 2

http://hg.mozilla.org/projects/devtools/rev/19337c6ac3ef
Attachment #529549 - Attachment description: rename workspace to scratchpad 2 → [in-devtools] rename workspace to scratchpad 2
I just found the strings to translate on mozilla-central. For the future, when you add a commandkey please call it NAME.commandkey, not NAME.key (you mixed both styles), it's a lot easier to spot them.
(Assignee)

Comment 26

6 years ago
(In reply to comment #25)
> I just found the strings to translate on mozilla-central. For the future,
> when you add a commandkey please call it NAME.commandkey, not NAME.key (you
> mixed both styles), it's a lot easier to spot them.

Should we add a follow-up bug to fix this?
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
tracking-firefox6: --- → ?
Resolution: --- → FIXED
Whiteboard: [workspace][scratchpad][fixed-in-devtools] → [workspace][scratchpad][fixed-in-devtools][merged-to-mozilla-central]
Target Milestone: --- → Firefox 6
(Assignee)

Comment 27

6 years ago
Comment on attachment 529549 [details] [diff] [review]
[checked-in] rename workspace to scratchpad 2

http://hg.mozilla.org/mozilla-central/rev/19337c6ac3ef
Attachment #529549 - Attachment description: [in-devtools] rename workspace to scratchpad 2 → [checked-in] rename workspace to scratchpad 2
(In reply to comment #26)
> Should we add a follow-up bug to fix this?

Let's see what Axel thinks, I'm not sure if there are automated tools that rely on those keys being called like that. Usually we don't localize command keys, so it would be somehow a low impact change.
This is done - don't think we need to track it for firefox6
tracking-firefox6: ? → -

Comment 30

6 years ago
Verified fixed on:
Windows 7:
Mozilla/5.0 (Windows NT 6.1; rv:6.0a2) Gecko/20110525 Firefox/6.0a2
Window XP:
Mozilla/5.0 (Windows NT 5.1; rv:6.0a2) Gecko/20110525 Firefox/6.0a2
Mac OS 10.6
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:6.0a2) Gecko/20110525 Firefox/6.0a2 
Linux i686:
Mozilla/5.0 (X11; Linux i686; rv:6.0a2) Gecko/20110525 Firefox/6.0a2

*Note: Scratchpad is available. Marking this bug as Verified
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.