Closed
Bug 653148
Opened 15 years ago
Closed 15 years ago
Document `self.on` instead of `on`, mainly used by context-menu
Categories
(Add-on SDK Graveyard :: Documentation, defect, P1)
Add-on SDK Graveyard
Documentation
Tracking
(Not tracked)
RESOLVED
FIXED
1.0
People
(Reporter: ochameau, Unassigned)
Details
(Keywords: APIchange, relnote)
Attachments
(1 file)
|
6.23 KB,
patch
|
Details | Diff | Splinter Review |
We are going to introduce a breaking change in 1.0b5.
We were used to call `on` directly in globals, but we recently removed it from globals in order to limit global scope pollution.
So we have remove all direct `on` uses and advertise the use of `self.on` in all content scripts.
Attachment #528606 -
Flags: review?(wbamberg)
|
||
Comment 1•15 years ago
|
||
P1 for 1.0, although we'll take for 1.0b5 if it's ready in time.
Priority: -- → P1
Target Milestone: --- → 1.0
|
||
Comment 2•15 years ago
|
||
Fixed as part of bug 653109 by https://github.com/mozilla/addon-sdk/commit/fa651783509bcd11127369b2a8c828b58c057018
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
|
||
Updated•14 years ago
|
Attachment #528606 -
Flags: review?(wbamberg)
You need to log in
before you can comment on or make changes to this bug.
Description
•