653180 - [webby] Store http auth credentials for staging servers

Status: RESOLVED FIXED

(Webtools Graveyard :: Elmo, defect)

Description

[Staś Małolepszy :stas]

...and show them to the logged-in users.

This way we don't have to send the creds out via emails to individual localizers.

Comment 1

[Staś Małolepszy :stas]

Attachment: Patch

+ some SQL to run:

alter table `webby_project` add `stage_login` varchar(80);
alter table `webby_project` add `stage_passwd` varchar(80);

Comment 2

[Staś Małolepszy :stas]

Forgot to mention: this patch is created based on the playdoh branch, as we will most likely move to it in the next couple of hours.

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 528652 [details] [diff] [review]
Patch

check if the user is logged in

Comment 4

[Staś Małolepszy :stas]

Attachment: grrr, new patch

I remembered to put this in, and didn't, in the end.  Here's the updated patch.

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 528661 [details] [diff] [review]
grrr, new patch

Review of attachment 528661 [details] [diff] [review]:

good one!

Comment 6

[Axel Hecht [:Pike]]

Comment on attachment 528661 [details] [diff] [review]
grrr, new patch

I wonder if the stage URL could include the user name and password for logged-in users?

Comment 7

[Staś Małolepszy :stas]

Attachment: Add migration data

Peter suggested that I use schematic migrations to deal with the sql.

Comment 8

[Peter Bengtsson [:peterbe]]

Comment on attachment 528809 [details] [diff] [review]
Add migration data

Review of attachment 528809 [details] [diff] [review]:

r=me

Comment 9

[Staś Małolepszy :stas]

Attachment: Add stage_auth_url field

As suggested by Axel, this adds the stage_auth_url field.  It's the simplest approach, I know I could have probably leveraged stage_url and insert the credentials into it, but since we're only adding projects every couple of weeks, I figured that the benefit wasn't worth putting any more time into this.

Comment 10

[Axel Hecht [:Pike]]

Comment on attachment 528858 [details] [diff] [review]
Add stage_auth_url field

Review of attachment 528858 [details] [diff] [review]:

r=me with the permission nit.

::: apps/webby/templates/webby/project.html
@@ +99,5 @@
     <li><a href="{{project.verbatim_url}}">Verbatim</a></li>
     <li><a href="{{project.l10n_repo_url}}">L10n repository</a></li>
     <li><a href="{{project.code_repo_url}}">Project repository</a></li>
+    <li>
+      {% if perms.webby.change_weblocale and project.stage_auth_url %}

Reading views.py, it seems that add_weblocale is the localizer permission, and change_weblocale is the admin permission. Should be add_locale, thus.

Comment 11

[Staś Małolepszy :stas]

https://github.com/mozilla/elmo/commit/fcd951e3b56915d51acc048c7d77e8a048f1314f

Comment 12

[Staś Małolepszy :stas]

Axel and I have tested this on /test/, and I would like to deploy this patch on production asap, before we switch to playdoh.  This is slightly more involved, so I filed a follow-up bug 653553.