653203 - [stage] Facebook message has our staging url

Status: VERIFIED FIXED

(Websites Graveyard :: markup.mozilla.org, defect, P1)

Description

[Matt Brandt [:mbrandt]]

Attachment: Dialog for Facebook post

This may be intentional but I wanted to check (nudging is always better than assuming), the url in the Facebook message currently points to our staging environment.

"https://markup.allizom.org/en/#/linear/YtCx
https://markup.allizom.org/en/#/linear/YtCx"

Additionally did we want a more verbose message about Markup to be included in the Facebook post? Currently only the above urls are being posted to a users wall.

Please see screenshot.

Comment 1

[Matt Brandt [:mbrandt]]

Attachment: Facebook wall post

And because more is merrier ... here's another screen grab :)

Comment 2

[Matt Brandt [:mbrandt]]

lvmesa, nudge ... nudge :) Any thoughts on this? see comment 0.

Comment 3

[Laura Mesa [:lmesa] [:lvmesa]]

We should be adding a message. I'll upload one tomorrow morning.

Comment 4

[Matt Brandt [:mbrandt]]

Thanks Laura. Also (In reply to comment #3)
> We should be adding a message. I'll upload one tomorrow morning.
Thanks Laura. Do we also need to update the urls to point to prod?

Comment 5

[Laura Mesa [:lmesa] [:lvmesa]]

Yes, they should point to production--as should twitter--but this is assuming all of this wasn't intentional. Tbg--can you confirm intention?

Comment 6

[Matt Brandt [:mbrandt]]

(In reply to comment #5)
> as should twitter--but this is assuming all of this wasn't intentional. 
> Tbg--can you confirm intention?

Just for reference, here's the twitter bug 652891.

Comment 7

[Laura Mesa [:lmesa] [:lvmesa]]

Message should be:

"The Web belongs to all of us. Make your mark and show your support for the
world's largest public resource."

Comment 8

[claudia // barbarian]

In response to Laura's comment (#5), because we were testing, they were set to staging. However, now that we are updating, the URLs should point to production.

Comment 9

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Ozten, please verify that the code is setup to use the production url once pushed?  If this is not the case, please assign back to TBG.  Thanks!

Comment 10

[Laura Mesa [:lmesa] [:lvmesa]]

Ozten--just wanted to check in here

Comment 11

[Austin King [:ozten]]

I have not started looking into this. I hope to look into it today.

Comment 12

[Austin King [:ozten]]

It looks like we're using jquery-socialShare which uses the current url.

On my dev instance, I see it sharing my dev url.

Comment 13

[Matt Brandt [:mbrandt]]

Thanks ozten! I'll wait to close this once I'm able to verify on prod.

Comment 14

[Matt Brandt [:mbrandt]]

Attachment: Missing Facebook Text

Testing on dev, the url in the facebook message updates correctly however I'm not seeing the updated message in comment 7.

"The Web belongs to all of us. Make your mark and show your support for the
world's largest public resource."

Comment 15

[[:brez]]

As long as you are testing on staging, you will see staging URLs, after all that is what you are sharing.

Comment 16

[[:brez]]

Re. the text we're setting the 't' variable but facebook isn't using the data - the likely cause is because it is behind the basic auth for staging, i.e. FB can't get back to the URL to scrape meta tags (which we have in place) - best option is to just put into production (or turn off basic auth which isn't recommended) - closing this because there's nothing more to do and will magically fix itself once in production

Comment 17

[Adam Miller]

Updated the copy here: 

https://github.com/mozilla/markup/commit/b884aa6abe9ecdcce985669473b160035e718bdc

Comment 18

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on production:

https://markup.mozilla.org/

Comment 19

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot