JSON e15_12_1.as and e15_12_2.as test must restore default prototype.toString values.

VERIFIED FIXED in Q3 11 - Serrano

Status

Tamarin
Tools
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: Chris Peyer, Assigned: Dan Schaffer)

Tracking

unspecified
Q3 11 - Serrano
Bug Flags:
in-testsuite +
flashplayer-bug -
flashplayer-triage +

Details

(Whiteboard: WE:2879805)

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
The JSON e15_12_1.as and e15_12_2.as tests are setting Object.prototype.toString and Array.prototype.toString methods and not setting them back causing many subsequent tests in the ATS to fail (the player is not reset between tests).

Need to fix and re-export.
Flags: in-testsuite+
Flags: flashplayer-triage+
Flags: flashplayer-bug-
(Reporter)

Comment 1

7 years ago
Created attachment 528709 [details] [diff] [review]
Restore prototype methods at end of test.

I've already updated the swfs in the ATS.  Please push if you r+.
Assignee: nobody → cpeyer
Status: NEW → ASSIGNED
Attachment #528709 - Flags: review?(dschaffe)
(Assignee)

Updated

7 years ago
Attachment #528709 - Flags: review?(dschaffe) → review+
I believe this still needs to be pushed, both to TR and to TR-serrano.
Whiteboard: WE:2879805
Target Milestone: --- → Q3 11 - Serrano
(assigning to Dan so that this gets pushed to the right places.  Please note Watson ticket listed on Whiteboad as well; I will reassign that Watson ticket shortly.)
Assignee: cpeyer → dschaffe

Comment 4

7 years ago
changeset: 6362:273f754f6f0a
user:      Dan Schaffer <dschaffe@adobe.com>
summary:   bug 653242: restore prototype.toString for JSON e15_12_1.as and e15_12_2.as tests (r=dschaffe)

http://hg.mozilla.org/tamarin-redux/rev/273f754f6f0a
(Assignee)

Comment 5

7 years ago
I rebuilt for ATS and pushed into the p4 ATS10AS3 Staging repo.  I will request Alvin to move from Staging to Shipping and unplato the tests once the files have been updated.  I will update the watson bug also.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Assignee)

Comment 6

7 years ago
Also pushed into tamarin-redux-serrano:

changeset:   6300:a5bee2b7701e
tag:         tip
user:        Dan Schaffer <dschaffe@adobe.com>
date:        Tue May 31 16:36:09 2011 -0400
summary:     bug 653242: restore prototype.toString for JSON e15_12_1.as and e15_12_2.as tests (r=dschaffe)
(Assignee)

Updated

7 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.