Closed Bug 653244 Opened 8 years ago Closed 8 years ago

Error and Math builtins should be eagerly inited

Categories

(Tamarin Graveyard :: Virtual Machine, defect, minor)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: stejohns, Unassigned)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
Currently we lazily init Math and Error builtins; this is silly, since every Flash/AIR app is going to use them. We can trivially reduce the size of the init code by lumping these in with the other eagerly-inited builtins.
Attachment #528708 - Flags: superreview?(edwsmith)
Attachment #528708 - Flags: review?(lhansen)
Attachment #528708 - Flags: review?(lhansen) → review+
Comment on attachment 528708 [details] [diff] [review]
Patch

Not every app will use every Error object, but this still seems like a safe bet.
Attachment #528708 - Flags: superreview?(edwsmith) → superreview+
6242:9b955600941d
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
changeset: 6259:e8fd55f5cf37
user:      Steven Johnson <stejohns@adobe.com>
summary:   Back out fix for Bug 653244 (Error and Math builtins should be eagerly inited); causes issues with Flex tools that need attention before it can land. (Backed out changeset 9b955600941d)

http://hg.mozilla.org/tamarin-redux/rev/e8fd55f5cf37
I've backed this out; it turns out that Flex compiler/linker tools are affected by this change (!), as they can make assumptions about which scripts export which classes. These assumptions need to be corrected but until they do, landing this will cause severe integration pain.
You need to log in before you can comment on or make changes to this bug.