simplify nsSMILAnimationController construction

RESOLVED FIXED in Firefox 5

Status

()

Core
SVG
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

Trunk
mozilla6
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox5 fixed, firefox6 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
While looking at another bug, I noticed that nsSMILAnimationController construction/initialization is much more COM-ish and messy than it needs to be. 

Filing this bug on cleaning that up.
(Assignee)

Comment 1

6 years ago
Created attachment 528725 [details] [diff] [review]
fix

Here's the fix.

Basically, NS_NewSMILAnimationController() is only ever called once, and it calls both the nsSMILAnimationController constructor and Init().  (and it's the only client of those)

So I'm merging all of the above into the nsSMILAnimationController constructor.
Attachment #528725 - Flags: review?(birtles)

Updated

6 years ago
Attachment #528725 - Flags: review?(birtles) → review+
(Assignee)

Comment 2

6 years ago
Landed: http://hg.mozilla.org/mozilla-central/rev/fc0d870dadf5
Flags: in-testsuite-
Target Milestone: --- → mozilla6
(Assignee)

Updated

6 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Updated

6 years ago
Blocks: 653238
(Assignee)

Comment 3

6 years ago
Comment on attachment 528725 [details] [diff] [review]
fix

This needs to land on aurora in order for Bug 653238 and Bug 654015 to land.  

Very low-risk -- this just merges a few constructor-ish functions together for simplicity, with no functional change.  (See summary in comment 1.)

Requesting approval for both aurora and beta so this can land with Bug 653238 and Bug 654015.
Attachment #528725 - Flags: approval-mozilla-beta?
Attachment #528725 - Flags: approval-mozilla-aurora?
(Assignee)

Comment 4

6 years ago
(In reply to comment #3)
> This needs to land on aurora in order for Bug 653238 and Bug 654015 to land.
(s/aurora/aurora and beta/)

Updated

6 years ago
Attachment #528725 - Flags: approval-mozilla-beta?
Attachment #528725 - Flags: approval-mozilla-beta+
Attachment #528725 - Flags: approval-mozilla-aurora?
Attachment #528725 - Flags: approval-mozilla-aurora+
(Assignee)

Comment 5

6 years ago
Landed on aurora and beta:
 http://hg.mozilla.org/releases/mozilla-aurora/rev/1fe1326cd046

 http://hg.mozilla.org/releases/mozilla-beta/rev/d216d3297c5a
status-firefox5: --- → fixed
(Assignee)

Updated

6 years ago
status-firefox6: --- → fixed
You need to log in before you can comment on or make changes to this bug.