653270 - simplify nsSMILAnimationController construction

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Daniel Holbert [:dholbert]]

While looking at another bug, I noticed that nsSMILAnimationController construction/initialization is much more COM-ish and messy than it needs to be. 

Filing this bug on cleaning that up.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

Here's the fix.

Basically, NS_NewSMILAnimationController() is only ever called once, and it calls both the nsSMILAnimationController constructor and Init().  (and it's the only client of those)

So I'm merging all of the above into the nsSMILAnimationController constructor.

Comment 2

[Daniel Holbert [:dholbert]]

Landed: http://hg.mozilla.org/mozilla-central/rev/fc0d870dadf5

Comment 3

[Daniel Holbert [:dholbert]]

Comment on attachment 528725 [details] [diff] [review]
fix

This needs to land on aurora in order for Bug 653238 and Bug 654015 to land.  

Very low-risk -- this just merges a few constructor-ish functions together for simplicity, with no functional change.  (See summary in comment 1.)

Requesting approval for both aurora and beta so this can land with Bug 653238 and Bug 654015.

Comment 4

[Daniel Holbert [:dholbert]]

(In reply to comment #3)
> This needs to land on aurora in order for Bug 653238 and Bug 654015 to land.
(s/aurora/aurora and beta/)

Comment 5

[Daniel Holbert [:dholbert]]

Landed on aurora and beta:
 http://hg.mozilla.org/releases/mozilla-aurora/rev/1fe1326cd046

 http://hg.mozilla.org/releases/mozilla-beta/rev/d216d3297c5a