Closed
Bug 653270
Opened 15 years ago
Closed 15 years ago
simplify nsSMILAnimationController construction
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla6
People
(Reporter: dholbert, Assigned: dholbert)
References
Details
Attachments
(1 file)
|
5.71 KB,
patch
|
jwatt
:
review+
asa
:
approval-mozilla-aurora+
asa
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
While looking at another bug, I noticed that nsSMILAnimationController construction/initialization is much more COM-ish and messy than it needs to be.
Filing this bug on cleaning that up.
| Assignee | ||
Comment 1•15 years ago
|
||
Here's the fix.
Basically, NS_NewSMILAnimationController() is only ever called once, and it calls both the nsSMILAnimationController constructor and Init(). (and it's the only client of those)
So I'm merging all of the above into the nsSMILAnimationController constructor.
Attachment #528725 -
Flags: review?(birtles)
Updated•15 years ago
|
Attachment #528725 -
Flags: review?(birtles) → review+
| Assignee | ||
Comment 2•15 years ago
|
||
Flags: in-testsuite-
Target Milestone: --- → mozilla6
| Assignee | ||
Updated•15 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
| Assignee | ||
Comment 3•15 years ago
|
||
Comment on attachment 528725 [details] [diff] [review]
fix
This needs to land on aurora in order for Bug 653238 and Bug 654015 to land.
Very low-risk -- this just merges a few constructor-ish functions together for simplicity, with no functional change. (See summary in comment 1.)
Requesting approval for both aurora and beta so this can land with Bug 653238 and Bug 654015.
Attachment #528725 -
Flags: approval-mozilla-beta?
Attachment #528725 -
Flags: approval-mozilla-aurora?
| Assignee | ||
Comment 4•15 years ago
|
||
(In reply to comment #3)
> This needs to land on aurora in order for Bug 653238 and Bug 654015 to land.
(s/aurora/aurora and beta/)
Updated•15 years ago
|
Attachment #528725 -
Flags: approval-mozilla-beta?
Attachment #528725 -
Flags: approval-mozilla-beta+
Attachment #528725 -
Flags: approval-mozilla-aurora?
Attachment #528725 -
Flags: approval-mozilla-aurora+
| Assignee | ||
Comment 5•15 years ago
|
||
Landed on aurora and beta:
http://hg.mozilla.org/releases/mozilla-aurora/rev/1fe1326cd046
http://hg.mozilla.org/releases/mozilla-beta/rev/d216d3297c5a
status-firefox5:
--- → fixed
| Assignee | ||
Updated•15 years ago
|
status-firefox6:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•