653319 - Remove devicemanager-utils.py & devicemanager-run-test.py from /build/mobile/ since they are now unused

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[Ed Morley [:emorley]]

My patch in bug 652506 removes the last user of devicemanager-utils.py (which was only used under WinCE), so the file can now be removed:
http://mxr.mozilla.org/mozilla-central/search?string=devicemanager-utils.py

Comment 1

[Ed Morley [:emorley]]

In fact, /build/mobile/devicemanager-run-test.py can also be removed:
http://mxr.mozilla.org/mozilla-central/search?string=devicemanager-run-test.py

Comment 2

[Ed Morley [:emorley]]

Attachment: Hg remove devicemanager-utils.py & devicemanager-run-test.py

Hg removes devicemanager-utils.py & devicemanager-run-test.py.

Blassey, after our IRC chat I checked and nothing else in the tree is using this any more (see MXR links above). Asking you for review, since you were the last one to touch the two files. 

Thanks!

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 528776 [details] [diff] [review]
Hg remove devicemanager-utils.py & devicemanager-run-test.py

As I said on irc, you should check with some one from a-team because I'm pretty sure that this is used for android testing.

Comment 4

[Ed Morley [:emorley]]

I was under the impression that android tests are now on m-c; and as my MXR result since our chat didn't find anything there (see comment 2), then they aren't using it.

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

you could push to try to test your theory

Comment 6

[Ed Morley [:emorley]]

Passed try: http://dev.philringnalda.com/tbpl/?tree=Try&rev=890f09eb3976

Comment 7

[cmtalbert]

Comment on attachment 528776 [details] [diff] [review]
Hg remove devicemanager-utils.py & devicemanager-run-test.py

These two files are not used because we have been focused with RelEng to get the tests that are packaged with make packaged-tests tested by the buildbot automation.  This includes things like mochitest, reftest, crashtest, jsreftest, xpchsell.  These two files are used to run C++ tests on devices and have not been touched in a long while because our team has been focused on these other test systems.  

(C++ tests are not packaged with make package-tests because they rely heavily on being run from the build environment, and must be run with access to many of those libraries that are not necessary for the other tests.)

I'd prefer we leave these two small files in the tree so that we have a place to start from to get the C++ tests working once we finish pushing the automation through for the other test harnesses.


Sorry it took so long to get to this review.

Comment 8

[Ed Morley [:emorley]]

Hi Clint - that makes sense; thanks for the background info :-)

Will mark this as wontfix for now.