653409 - Failure to build dist/xpi-stage/locale-en-US/install.rdf

Status: RESOLVED DUPLICATE of bug 569365

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

Attachment: Patch

I get the following failure on Windows, with the supposedly latest MozillaBuild, perl telling me it's version 5.6.1 built for msys:

Couldn't open /c/Users/mh/mozilla-central/obj-i686-pc-mingw32/browser/locales/c:/Users/mh/mozilla-central/browser/locales/generic/install.rdf: No such file or directory
c:\Users\mh\mozilla-central\toolkit\locales\l10n.mk:199:0: command '/bin/sh /c/Users/mh/mozilla-central/build/msys-perl-wrapper c:/Users/mh/mozilla-central/config/preprocessor.pl -DOSTYPE=\"WINNT6.1\" -DOSARCH=WINNT -DAB_CD=en-US -DMOZ_LANGPACK_EID=[e-mail] -DMOZ_APP_VERSION=6.0a1 -DLOCALE_SRCDIR=c:/Users/mh/mozilla-central/browser/locales/en-US -DPKG_BASENAME="firefox-6.0a1.en-US.win32" -DPKG_INST_BASENAME="firefox-6.0a1.en-US.win32.installer"  -DDLL_PREFIX= -DDLL_SUFFIX=.dll -DBIN_SUFFIX=.exe -D_CRT_SECURE_NO_DEPRECATE=1 -D_CRT_NONSTDC_NO_DEPRECATE=1 -DHAVE_SEH_EXCEPTIONS=1 -DHAVE_WINSDKVER_H=1 -DMOZ_MSVC_STL_WRAP__Throw=1 -DWINVER=0x502 -D_WIN32_WINNT=0x502 -D_WIN32_IE=0x0500 -DMOZ_WINSDK_TARGETVER=0x06010000 -DMOZ_NTDDI_WS03=0x05020000 -DMOZ_NTDDI_LONGHORN=0x06000000 -DMOZ_NTDDI_WIN7=0x06010000 -DHAVE_IO_H=1 -DHAVE_SETBUF=1 -DHAVE_ISATTY=1 -DX_DISPLAY_MISSING=1 -DMOZILLA_VERSION=\"6.0a1\" -DMOZILLA_VERSION_U=6.0a1 -DHAVE_SNPRINTF=1 -D_WINDOWS=1 -DWIN32=1 -DXP_WIN=1 -DXP_WIN32=1 -DHW_THREADS=1 -DSTDC_HEADERS=1 -DWIN32_LEAN_AND_MEAN=1 -DNO_X11=1 -DHAVE_OLEACC_IDL=1 -DHAVE_ATLBASE_H=1 -DHAVE_MMINTRIN_H=1 -D_X86_=1 -DD_INO=d_ino -DNS_ALWAYS_INLINE= -DNS_ATTR_MALLOC= -DNS_WARN_UNUSED_RESULT= -DNS_NORETURN= -DMALLOC_H=\<malloc.h\> -DHAVE_FORCEINLINE=1 -DHAVE_LOCALECONV=1 -DNS_ENABLE_TSF=1 -DMOZ_PHOENIX=1 -DMOZ_BUILD_APP=browser -DMOZ_PDF_PRINTING=1 -DMOZ_INSTRUMENT_EVENT_LOOP=1 -DMOZ_DISTRIBUTION_ID=\"org.mozilla\" -DIBMBIDI=1 -DNS_PRINTING=1 -DNS_PRINT_PREVIEW=1 -DMOZ_OGG=1 -DMOZ_WEBM=1 -DVPX_X86_ASM=1 -DMOZ_WAVE=1 -DMOZ_SYDNEYAUDIO=1 -DMOZ_MEDIA=1 -DMOZ_VORBIS=1 -DMOZ_XTF=1 -DMOZ_CRASHREPORTER=1 -DMOZ_CRASHREPORTER_ENABLE_PERCENT=100 -DLIBJPEG_TURBO_X86_ASM=1 -DMOZ_MATHML=1 -DMOZ_CSS_ANIMATIONS=1 -DMOZ_SVG=1 -DMOZ_SMIL=1 -DMOZ_UPDATER=1 -DMOZ_UPDATE_CHANNEL=default -DMOZ_FEEDS=1 -DMOZ_STORAGE=1 -DMOZ_SAFE_BROWSING=1 -DMOZ_URL_CLASSIFIER=1 -DMOZ_DEBUG_SYMBOLS=1 -DMOZ_LOGGING=1 -DMOZ_OMNIJAR=1 -DMOZ_USER_DIR=\"Mozilla\" -DMOZ_ENABLE_LIBXUL=1 -DMOZ_TREE_CAIRO=1 -DHAVE_UINT64_T=1 -DMOZ_TREE_PIXMAN=1 -DMOZ_XUL=1 -DMOZ_PROFILELOCKING=1 -DMOZ_RDF=1 -DBUILD_CTYPES=1 -DMOZ_MORKREADER=1 -DMOZ_PLACES=1 -DMOZ_SERVICES_SYNC=1 -DMOZ_APP_UA_NAME=\"\" -DMOZ_APP_UA_VERSION=\"6.0a1\" -DMOZ_UA_FIREFOX_VERSION=\"6.0a1\" -DMOZ_UA_BUILDID=\"\" -DMOZ_DLL_SUFFIX=\".dll\"  -Ic:/Users/mh/mozilla-central/toolkit/locales/en-US/defines.inc -Ic:/Users/mh/mozilla-central/browser/locales/en-US/defines.inc c:/Users/mh/mozilla-central/browser/locales/generic/install.rdf > ../../dist/xpi-stage/locale-en-US/install.rdf' failed, return code 2

So, the command does pass the "right" path, but preprocessor.pl seems to think it's a relative path...

It turns out that "simply" switching to Preprocessor.py gets rid of this.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

I thought we killed preprocessor.pl already?

Comment 2

[Mike Hommey [:glandium]]

Attachment: Patch

Oops, I couldn't spell python.

Comment 3

[Mike Hommey [:glandium]]

Ah, I should add that I was building with pymake instead of gmake. With gmake it works.

Comment 4

[(not currently active) Ted Mielczarek]

Yeah, that was bug 569365. So how did we miss this (and how did this code not completely break)?

Comment 5

[Mike Hommey [:glandium]]

(In reply to comment #1)
> I thought we killed preprocessor.pl already?

So, that was bug 569365, and it was reverted in changeset 858c9dd4c377.