653461 - avoid uses of enablePrivilege in style system mochitests

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P4)

Description

[David Baron :dbaron:]

I have patches to remove all but one of the uses of enablePrivilege in the layout/style/test/ mochitests.

The one remaining use is in test_bug405818.html, which I'm not immediately sure what to do about.

Comment 1

[David Baron :dbaron:]

Attachment: patch 1: fix use of prefs API

Comment 2

[David Baron :dbaron:]

Attachment: patch 2: convert uses of DOMWindowUtils

Comment 3

[David Baron :dbaron:]

Attachment: patch 3: convert use of zoom

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 528881 [details] [diff] [review]
patch 2: convert uses of DOMWindowUtils

Review of attachment 528881 [details] [diff] [review]:

::: layout/style/test/test_pointer-events.html
@@ +70,5 @@
                               modifiers,           // long
                               ignoreWindowBounds)  // boolean
 {
+  SpecialPowers.DOMWindowUtils.sendMouseEvent(type, x, y, button, clickCount,
+                                              modifiers, ignoreWindowBounds);

Just curious why this is using sendMouseEvent when we have many synthesizeMouse* functions in EventUtils.js?  I sort of prefer this simpler approach.

Comment 5

[David Baron :dbaron:]

Not sure; I didn't write it, and I'd rather not change it without doing more retesting that it's still testing the original bug.

That said, I find the EventUtils stuff pretty magical, and prefer this more explicit approach.

Comment 6

[Boris Zbarsky [:bzbarsky]]

This caller is passing true for ignoreWindowBounds, which is not something the synthesizeMouse stuff in EventUtils does.  That my matter in this case.  Or not.  It would take some looking at this test to make sure.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 528879 [details] [diff] [review]
patch 1: fix use of prefs API

r=me

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 528881 [details] [diff] [review]
patch 2: convert uses of DOMWindowUtils

r=me

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 528882 [details] [diff] [review]
patch 3: convert use of zoom

r=me

Comment 10

[David Baron :dbaron:]

https://hg.mozilla.org/mozilla-central/rev/2228e6343c47
https://hg.mozilla.org/mozilla-central/rev/442fe6006bbb
https://hg.mozilla.org/mozilla-central/rev/00d9bc4a9b9c

I'll call this bug fixed despite there being one left (see comment 0).

Comment 11

[David Baron :dbaron:]

Attachment: use SpecialPowers.wrap() for the last case

Well, SpecialPowers.wrap() makes the last case easy (though I wonder if it's an overused tool), assuming this looks reasonable.

Comment 12

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 659077 [details] [diff] [review]
use SpecialPowers.wrap() for the last case

r=me

Comment 13

[David Baron :dbaron:]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9a64e93daf5c

Comment 14

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9a64e93daf5c