653484 - Add an OSR configuration of the shell to be built and tested into buildbot

Status: VERIFIED FIXED

(Tamarin Graveyard :: Build Config, defect, P3)

Description

[Brent Baker]

Buildbot should compile and do some light testing with the OSR feature enable to ensure that it continues to compile. 

This belongs in the deep phase of the build system.

I am not sure exactly what should be run to ensure that the feature is at least not failing, could be just a full acceptance pass, or maybe some of the performance testcases.

Comment 1

[James Sudduth]

Attachment: Add OSR builds and tests to the deep phase.

Adds osr builds and acceptance tests in the deep phase. Currently builds for Windows, Windows64, Mac, Mac64 and Linux. Linux-arm and linux-mips are not included because they are already the long pole for the compile phase; building only release for these two platforms would extend the compile phase by an estimated 7 to 8 minutes.

Comment 2

[Brent Baker]

Comment on attachment 547938 [details] [diff] [review]
Add OSR builds and tests to the deep phase.

Review of attachment 547938 [details] [diff] [review]:
-----------------------------------------------------------------

I think that we should be adding a run to the linux-arm and mips, your comment that they would increase the "compile" phase is not correct since all of this is in the "deep" phase.

::: build/buildbot/master/tamarinredux.py
@@ +876,5 @@
>      windows_64_deep_factory.addStep(test_generic(name="DebugDebugger-wordcode-interp", shellname="avmshell_sd_wordcode_64", vmargs="-Dinterp", config="", scriptargs=""))
>      windows_64_deep_factory.addStep(compile_generic(name="ReleaseDebugger-air", shellname="avmshell_air_64", args="--enable-override-global-new --enable-use-system-malloc --enable-debugger --target=x86_64-win", upload="true", features="+AVMSYSTEM_64BIT +AVMSYSTEM_AMD64 +AVMFEATURE_DEBUGGER +AVMFEATURE_OVERRIDE_GLOBAL_NEW +AVMFEATURE_USE_SYSTEM_MALLOC"))
>      windows_64_deep_factory.addStep(test_generic(name="ReleaseDebugger-air", shellname="avmshell_air_64", vmargs="", config="", scriptargs=""))
> +    windows_64_deep_factory.addStep(compile_generic(name="Release-osr", shellname="avmshell_osr_64", args="--enable-osr", upload="false", features="+AVMSYSTEM_32BIT +AVMSYSTEM_IA32 +AVMFEATURE_OSR"))
> +    windows_64_deep_factory.addStep(test_generic(name="Release-osr-17", shellname="avmshell_osr_64", vmargs="-osr=17", config="", scriptargs=""))

You will need to add this to the args:  --target=x86_64-win, and you need to be looking for these features: +AVMSYSTEM_64BIT +AVMSYSTEM_AMD64

@@ +1000,5 @@
>      mac64_deep_factory.addStep(test_generic(name="DebugDebugger-wordcode-interp", shellname="avmshell_sd_wordcode_64", vmargs="-Dinterp", config="", scriptargs=""))
>      mac64_deep_factory.addStep(compile_generic(name="ReleaseDebugger-air", shellname="avmshell_air_64", args="--target=x86_64-darwin --enable-override-global-new --enable-use-system-malloc --enable-debugger", upload="true", features="+AVMSYSTEM_64BIT +AVMSYSTEM_AMD64 +AVMFEATURE_DEBUGGER +AVMFEATURE_OVERRIDE_GLOBAL_NEW +AVMFEATURE_USE_SYSTEM_MALLOC"))
>      mac64_deep_factory.addStep(test_generic(name="ReleaseDebugger-air", shellname="avmshell_air_64", vmargs="", config="", scriptargs=""))
> +    mac64_deep_factory.addStep(compile_generic(name="Release-osr", shellname="avmshell_osr_64", args="--enable-osr --target=x86_64-darwin --mac-sdk=105", upload="false", features="+AVMSYSTEM_32BIT +AVMSYSTEM_IA32 +AVMFEATURE_OSR"))
> +    mac64_deep_factory.addStep(test_generic(name="Release-osr-17", shellname="avmshell_osr_64", vmargs="-osr=17", config="", scriptargs=""))

Need to check that these features are enabled: +AVMSYSTEM_64BIT +AVMSYSTEM_AMD64

Comment 3

[James Sudduth]

Attachment: Add OSR builds and tests to the deep phase.

Fixes 64-bit oversight, adds compile and test steps to linux-arm and linux-mips.

Comment 4

[Tamarin Bot]

changeset: 6486:03d15fa118df
user:      Brent Baker <[e-mail]>
summary:   Bug 653484: Add OSR config compile and testing into the deep phase of the build (p=jsudduth,brbaker r=brbaker)

http://hg.mozilla.org/tamarin-redux/rev/03d15fa118df

Comment 5

[Brent Baker]

Attachment: v2. Add OSR builds and tests to the deep phase.

Tweaked the patch in the following ways (NOTE: I pushed and deployed the patch assuming positive review)

- mac32/64 feature check was reversed
- mac32 added --target=i686-darwin to the compile step
- config string for SSH runs needed to have the vmargs string appended
- remove the build-check and upload scripts for the mips and arm builders, they are not necessary
- add compiler overrides to the mips and arm environment.sh

Comment 6

[James Sudduth]

Attachment: Additional patch to add debug builds and osr=0 tests

Adds OSR enabled debug builds. Also adds Release and Debug tests with '-osr=0' to test builds with OSR enabled but turned off.

Comment 7

[Tamarin Bot]

changeset: 6512:8384b9fb9116
user:      James Sudduth <[e-mail]>
summary:   Bug 653484 - Add an OSR configuration of the shell to be built and tested into buildbot - additional tests (r=cpeyer)

http://hg.mozilla.org/tamarin-redux/rev/8384b9fb9116