Add an OSR configuration of the shell to be built and tested into buildbot

VERIFIED FIXED in Q4 11 - Anza

Status

Tamarin
Build Config
P3
normal
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: Brent Baker, Assigned: James Sudduth)

Tracking

(Depends on: 1 bug)

unspecified
Q4 11 - Anza
Bug Flags:
in-testsuite ?
flashplayer-qrb +
flashplayer-bug -
flashplayer-triage +

Details

(Whiteboard: buildbot)

Attachments

(2 attachments, 2 obsolete attachments)

(Reporter)

Description

7 years ago
Buildbot should compile and do some light testing with the OSR feature enable to ensure that it continues to compile. 

This belongs in the deep phase of the build system.

I am not sure exactly what should be run to ensure that the feature is at least not failing, could be just a full acceptance pass, or maybe some of the performance testcases.
Flags: in-testsuite?
Flags: flashplayer-triage+
Flags: flashplayer-qrb?
Flags: flashplayer-bug-

Updated

7 years ago
Assignee: nobody → jsudduth
Status: NEW → ASSIGNED
Flags: flashplayer-qrb? → flashplayer-qrb+
Priority: -- → P3
Target Milestone: --- → Q4 11 - Anza
(Assignee)

Comment 1

7 years ago
Created attachment 547938 [details] [diff] [review]
Add OSR builds and tests to the deep phase.

Adds osr builds and acceptance tests in the deep phase. Currently builds for Windows, Windows64, Mac, Mac64 and Linux. Linux-arm and linux-mips are not included because they are already the long pole for the compile phase; building only release for these two platforms would extend the compile phase by an estimated 7 to 8 minutes.
Attachment #547938 - Flags: review?(brbaker)
Attachment #547938 - Flags: feedback?(trbaker)
(Reporter)

Comment 2

7 years ago
Comment on attachment 547938 [details] [diff] [review]
Add OSR builds and tests to the deep phase.

Review of attachment 547938 [details] [diff] [review]:
-----------------------------------------------------------------

I think that we should be adding a run to the linux-arm and mips, your comment that they would increase the "compile" phase is not correct since all of this is in the "deep" phase.

::: build/buildbot/master/tamarinredux.py
@@ +876,5 @@
>      windows_64_deep_factory.addStep(test_generic(name="DebugDebugger-wordcode-interp", shellname="avmshell_sd_wordcode_64", vmargs="-Dinterp", config="", scriptargs=""))
>      windows_64_deep_factory.addStep(compile_generic(name="ReleaseDebugger-air", shellname="avmshell_air_64", args="--enable-override-global-new --enable-use-system-malloc --enable-debugger --target=x86_64-win", upload="true", features="+AVMSYSTEM_64BIT +AVMSYSTEM_AMD64 +AVMFEATURE_DEBUGGER +AVMFEATURE_OVERRIDE_GLOBAL_NEW +AVMFEATURE_USE_SYSTEM_MALLOC"))
>      windows_64_deep_factory.addStep(test_generic(name="ReleaseDebugger-air", shellname="avmshell_air_64", vmargs="", config="", scriptargs=""))
> +    windows_64_deep_factory.addStep(compile_generic(name="Release-osr", shellname="avmshell_osr_64", args="--enable-osr", upload="false", features="+AVMSYSTEM_32BIT +AVMSYSTEM_IA32 +AVMFEATURE_OSR"))
> +    windows_64_deep_factory.addStep(test_generic(name="Release-osr-17", shellname="avmshell_osr_64", vmargs="-osr=17", config="", scriptargs=""))

You will need to add this to the args:  --target=x86_64-win, and you need to be looking for these features: +AVMSYSTEM_64BIT +AVMSYSTEM_AMD64

@@ +1000,5 @@
>      mac64_deep_factory.addStep(test_generic(name="DebugDebugger-wordcode-interp", shellname="avmshell_sd_wordcode_64", vmargs="-Dinterp", config="", scriptargs=""))
>      mac64_deep_factory.addStep(compile_generic(name="ReleaseDebugger-air", shellname="avmshell_air_64", args="--target=x86_64-darwin --enable-override-global-new --enable-use-system-malloc --enable-debugger", upload="true", features="+AVMSYSTEM_64BIT +AVMSYSTEM_AMD64 +AVMFEATURE_DEBUGGER +AVMFEATURE_OVERRIDE_GLOBAL_NEW +AVMFEATURE_USE_SYSTEM_MALLOC"))
>      mac64_deep_factory.addStep(test_generic(name="ReleaseDebugger-air", shellname="avmshell_air_64", vmargs="", config="", scriptargs=""))
> +    mac64_deep_factory.addStep(compile_generic(name="Release-osr", shellname="avmshell_osr_64", args="--enable-osr --target=x86_64-darwin --mac-sdk=105", upload="false", features="+AVMSYSTEM_32BIT +AVMSYSTEM_IA32 +AVMFEATURE_OSR"))
> +    mac64_deep_factory.addStep(test_generic(name="Release-osr-17", shellname="avmshell_osr_64", vmargs="-osr=17", config="", scriptargs=""))

Need to check that these features are enabled: +AVMSYSTEM_64BIT +AVMSYSTEM_AMD64
Attachment #547938 - Flags: review?(brbaker) → review+
(Assignee)

Comment 3

7 years ago
Created attachment 548294 [details] [diff] [review]
Add OSR builds and tests to the deep phase.

Fixes 64-bit oversight, adds compile and test steps to linux-arm and linux-mips.
Attachment #547938 - Attachment is obsolete: true
Attachment #547938 - Flags: feedback?(trbaker)
Attachment #548294 - Flags: review?(brbaker)

Comment 4

7 years ago
changeset: 6486:03d15fa118df
user:      Brent Baker <brbaker@adobe.com>
summary:   Bug 653484: Add OSR config compile and testing into the deep phase of the build (p=jsudduth,brbaker r=brbaker)

http://hg.mozilla.org/tamarin-redux/rev/03d15fa118df
(Reporter)

Comment 5

7 years ago
Created attachment 548417 [details] [diff] [review]
v2. Add OSR builds and tests to the deep phase.

Tweaked the patch in the following ways (NOTE: I pushed and deployed the patch assuming positive review)

- mac32/64 feature check was reversed
- mac32 added --target=i686-darwin to the compile step
- config string for SSH runs needed to have the vmargs string appended
- remove the build-check and upload scripts for the mips and arm builders, they are not necessary
- add compiler overrides to the mips and arm environment.sh
Attachment #548294 - Attachment is obsolete: true
Attachment #548294 - Flags: review?(brbaker)
Attachment #548417 - Flags: review?(jsudduth)
(Assignee)

Updated

7 years ago
Attachment #548417 - Flags: review?(jsudduth) → review+
(Assignee)

Comment 6

7 years ago
Created attachment 550499 [details] [diff] [review]
Additional patch to add debug builds and osr=0 tests

Adds OSR enabled debug builds. Also adds Release and Debug tests with '-osr=0' to test builds with OSR enabled but turned off.
Attachment #550499 - Flags: review?(cpeyer)

Updated

7 years ago
Attachment #550499 - Flags: review?(cpeyer) → review+

Comment 7

7 years ago
changeset: 6512:8384b9fb9116
user:      James Sudduth <jsudduth@adobe.com>
summary:   Bug 653484 - Add an OSR configuration of the shell to be built and tested into buildbot - additional tests (r=cpeyer)

http://hg.mozilla.org/tamarin-redux/rev/8384b9fb9116
(Assignee)

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Assignee)

Updated

7 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.