653547 - Scrollbar in reCAPTCHA UI

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Richard Newman [:rnewman]]

Continuation from Bug 653307.

Comment 1

[Richard Newman [:rnewman]]

Attachment: Add minwidth to wizard. v1

Needs testing on Windows and Linux...

Comment 2

[Richard Newman [:rnewman]]

STR:

* New profile.
* Set up Sync.
* No horizontal scrollbar should be visible in captcha dialog.
* Please report any visual oddities.

Comment 3

[Philipp von Weitershausen [:philikon]]

Comment on attachment 528946 [details] [diff] [review]
Add minwidth to wizard. v1

No styling in XUL, please! You want to be modifying the CSS! Here's the one for OS X: https://mxr.mozilla.org/services-central/source/services-central/browser/themes/pinstripe/browser/syncSetup.css#3

I wonder if instead of making the wizard wider we can reduce the margin for the captcha browser (negative margins, if we have to.)

Comment 4

[Richard Newman [:rnewman]]

Attachment: Negative margins.

Negative margins work. Any tips on finding the minimum applicable value? I flat-out guessed, and it looks fine (presumably because XUL is centering the browser regardless), but I can't say I can back up the numbers with science.

Comment 5

[Richard Newman [:rnewman]]

Attachment: Updated appearance.

Comment 6

[Philipp von Weitershausen [:philikon]]

Comment on attachment 529165 [details] [diff] [review]
Negative margins.

All lengths in the wizard CSS so far are in 'em' units, in particular the left and right paddings that are constraining the captcha [1]. Introducing a value in 'px' here reminds me of the 1999 Mars Orbiter crash [2].

Also, you need (presumably) the same change in winstripe and gnomestripe.

[1] https://mxr.mozilla.org/services-central/source/services-central/browser/themes/pinstripe/browser/syncSetup.css#20
[2] https://secure.wikimedia.org/wikipedia/en/wiki/Mars_Climate_Orbiter#Communications_loss

Comment 7

[Richard Newman [:rnewman]]

(In reply to comment #6)

> All lengths in the wizard CSS so far are in 'em' units, in particular the left
> and right paddings that are constraining the captcha [1]. Introducing a value
> in 'px' here reminds me of the 1999 Mars Orbiter crash [2].

I disagree: the dimensions of the XUL browser element are in px, so it makes sense (to me at least) that additional spacing necessary to its correct display should be in the same units.

There will, of course, be a point at which pixel-sized page elements and em-sized pages must collide; I don't think the margin for the page element is the right choice in this case. The padding on the containing wizard page seems like a suitable point. (Sorry for the bad pun.)

Phrased differently: I can imagine font sizes that would cause a given em value to render this fix ineffective, by translating to an inadequate number of pixels. Ergo, we should specify the offset in pixels.


> Also, you need (presumably) the same change in winstripe and gnomestripe.

Gotcha. Need your help testing on Windows, though.

Comment 8

[Philipp von Weitershausen [:philikon]]

Bug 675823 fixed this.