Closed
Bug 653644
Opened 13 years ago
Closed 13 years ago
assert that CommonElementAnimationData are destroyed as expected
Categories
(Core :: CSS Parsing and Computation, defect, P3)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla5
| Tracking | Status | |
|---|---|---|
| firefox5 | --- | fixed |
| status1.9.2 | --- | unaffected |
| status1.9.1 | --- | unaffected |
People
(Reporter: dbaron, Assigned: dbaron)
Details
Attachments
(1 file)
|
3.19 KB,
patch
|
bzbarsky
:
review+
jpr
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
One issue that came up in today's security review of css3-animations was that CommonElementAnimationData should assert that it is destroyed as expected rather than via a direct call to its delete method.
Attachment #529027 -
Flags: review?(bzbarsky)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 529027 [details] [diff] [review] patch r=me
Attachment #529027 -
Flags: review?(bzbarsky) → review+
|
Assignee | |
Comment 2•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/509e62175dbf
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Priority: -- → P3
Resolution: --- → FIXED
|
|
Assignee | |
Updated•13 years ago
|
status1.9.1:
--- → unaffected
status1.9.2:
--- → unaffected
|
|
Assignee | |
Comment 3•13 years ago
|
||
Comment on attachment 529027 [details] [diff] [review] patch DEBUG-only code which would be nice to land on aurora (along with animations) so tests have a better chance of catching anything that goes wrong
Attachment #529027 -
Flags: approval-mozilla-aurora?
|
||
Comment 4•13 years ago
|
||
Comment on attachment 529027 [details] [diff] [review] patch Debug only for new feature is fine.
Attachment #529027 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
|
Assignee | |
Comment 5•13 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/0c533a76dc5a
status-firefox5:
--- → fixed
Target Milestone: mozilla6 → mozilla5
You need to log in
before you can comment on or make changes to this bug.
Description
•