assert that CommonElementAnimationData are destroyed as expected

RESOLVED FIXED in Firefox 5

Status

()

defect
P3
normal
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

Trunk
mozilla5
Points:
---

Firefox Tracking Flags

(firefox5 fixed, status1.9.2 unaffected, status1.9.1 unaffected)

Details

Attachments

(1 attachment)

Posted patch patchSplinter Review
One issue that came up in today's security review of css3-animations was that CommonElementAnimationData should assert that it is destroyed as expected rather than via a direct call to its delete method.
Attachment #529027 - Flags: review?(bzbarsky)
Comment on attachment 529027 [details] [diff] [review]
patch

r=me
Attachment #529027 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/509e62175dbf
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Priority: -- → P3
Resolution: --- → FIXED
Comment on attachment 529027 [details] [diff] [review]
patch

DEBUG-only code which would be nice to land on aurora (along with animations) so tests have a better chance of catching anything that goes wrong
Attachment #529027 - Flags: approval-mozilla-aurora?
Comment on attachment 529027 [details] [diff] [review]
patch

Debug only for new feature is fine.
Attachment #529027 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.