653674 - [webby] Self-refresh issues in web interface

Status: VERIFIED FIXED

(Webtools Graveyard :: Elmo, defect)

Description

[Anas Husseini [:linostar]]

When a localizer logins, the the locale opt-in listbox doesn't appear without shift+reload. When he/she opts in for a particular, the locale table doesn't get updated either without an explicit shift+reload.

Comment 1

[Staś Małolepszy :stas]

(In reply to comment #0)
> When a localizer logins, the the locale opt-in listbox doesn't appear without
> shift+reload.

I'll have a patch shortly.

> When he/she opts in for a particular, the locale table doesn't
> get updated either without an explicit shift+reload.

I can't repro this.

Comment 2

[Staś Małolepszy :stas]

Attachment: Patch

Comment 3

[Staś Małolepszy :stas]

(In reply to comment #1)

> I can't repro this.

Correction, I can see the issue now.

Comment 4

[Axel Hecht [:Pike]]

Comment on attachment 529068 [details] [diff] [review]
Patch

Review of attachment 529068 [details] [diff] [review]:

r=me

Comment 5

[Staś Małolepszy :stas]

(In reply to comment #3)
> (In reply to comment #1)
> 
> > I can't repro this.
> 
> Correction, I can see the issue now.

I only see this on production, not locally.  Something with the way we cache, probably.  Axel, Gandalf, Peter, any thoughts?

Comment 6

[Axel Hecht [:Pike]]

I usually say "ETag" when it comes down to caching, totally uninformed. It's got a VARY-ON cookie set, which should help against users with the wrong perms seeing the wrong page, maybe ETag based on latest WebLocale for the project?

Comment 7

[Staś Małolepszy :stas]

Fixed on master:

https://github.com/mozilla/elmo/commit/ac397c0c161596b1ae94a8a17bc31ee51075f916

Fixed on develop:

https://github.com/mozilla/elmo/commit/ac397c0c161596b1ae94a8a17bc31ee51075f916
https://github.com/mozilla/elmo/commit/f211011818b390ee082d0e2fcc6ac911984ab762


(In reply to comment #5)
> (In reply to comment #3)
> > (In reply to comment #1)
> > 
> > > I can't repro this.
> > 
> > Correction, I can see the issue now.
> 
> I only see this on production, not locally.  Something with the way we cache,
> probably.  Axel, Gandalf, Peter, any thoughts?

I filed bug 653719 to handle this.

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Anas, can you verify this is fixed on https://l10n-stage-sj.mozilla.org/?  Thanks!

Comment 9

[Anas Husseini [:linostar]]

Verified that the first issue is fixed. 
The second issue is now handled by bug 653719.