Closed
Bug 653713
Opened 14 years ago
Closed 14 years ago
editusers.cgi crashes when editing a user profile
Categories
(Bugzilla :: Administration, task)
Tracking
()
RESOLVED
FIXED
Bugzilla 4.2
People
(Reporter: erkiha, Assigned: jochen.wiedmann)
References
Details
(Keywords: regression)
Attachments
(1 file)
312 bytes,
patch
|
mkanat
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:2.0) Gecko/20100101 Firefox/4.0
Build Identifier: 4.1.2+
I get following error when trying to edit user:
URL: https://bugzilla.erki.net/bugzilla/editusers.cgi?action=edit&userid=95&matchvalue=login_name&groupid=6&grouprestrict=&matchtype=substr&matchstr=erki
undef error - Can't call method "extern_id_used" on an undefined value at Bugzilla/Auth/Verify/Stack.pm line 91.
Reproducible: Always
Reporter | ||
Comment 1•14 years ago
|
||
Probably related to this bug: Bug 423612
Comment 2•14 years ago
|
||
I cannot reproduce. What are your user_info_class and user_verify_class parameters set to?
Reporter | ||
Comment 3•14 years ago
|
||
user_info_class = CGI
user_verify_class = DB
Comment 4•14 years ago
|
||
OK, I can reproduce. I had user_info_class = Env,CGI, which is why I got no crash.
Severity: normal → blocker
Status: UNCONFIRMED → NEW
Depends on: 423612
Ever confirmed: true
Flags: blocking4.2+
Keywords: regression
OS: Linux → All
Hardware: x86_64 → All
Target Milestone: --- → Bugzilla 4.2
Version: unspecified → 4.1.2
Assignee | ||
Comment 5•14 years ago
|
||
I think, there's simply a "use List::MoreUtils qw(any)" missing.
Attachment #529596 -
Flags: review?(mkanat)
Comment 6•14 years ago
|
||
Comment on attachment 529596 [details] [diff] [review]
Proposed patch
I can't really test this right now--if you have tested this and it works, it's certainly something that needs to be done (and may have simply been my error when doing an adjustment on checkin).
Attachment #529596 -
Flags: review?(mkanat) → review+
Comment 7•14 years ago
|
||
We should have testcases that prove that auth continues to work in various forms.
Flags: testcase?
Updated•14 years ago
|
Flags: approval+
Updated•14 years ago
|
Assignee: administration → jochen.wiedmann
Status: NEW → ASSIGNED
Comment 8•14 years ago
|
||
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/Auth/Verify/Stack.pm
Committed revision 7809.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Summary: undef error - Can't call method "extern_id_used" on an undefined value at Bugzilla/Auth/Verify/Stack.pm line 91. → editusers.cgi crashes when editing a user profile
You need to log in
before you can comment on or make changes to this bug.
Description
•