Closed Bug 653717 Opened 9 years ago Closed 9 years ago

Add aurora branding to fennec

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set

Tracking

(firefox5 fixed)

VERIFIED FIXED
Tracking Status
firefox5 --- fixed

People

(Reporter: mfinkle, Assigned: mfinkle)

References

Details

Attachments

(2 files)

We need to add aurora branding to fennec. This includes any text and image changes.
i thought we were just doing nightly, beta, and final?  That is, we weren't going to do aurora yet
(In reply to comment #1)
> i thought we were just doing nightly, beta, and final?  That is, we weren't
> going to do aurora yet

I haven't seen this written anywhere, so I am moving ahead with the infra. We are making mozilla-aurora builds, so having some form of branding and android package id specific to aurora seems warranted.
Attached patch WIP 1Splinter Review
Basic changes. No image changes yet. Two things of note:
* Text change: Fennec -> Aurora
* Android package ID change: org.mozilla.fennec -> org.mozilla.aurora

I'll update this as we get images
Assignee: nobody → mark.finkle
(In reply to comment #1)
> i thought we were just doing nightly, beta, and final?  That is, we weren't
> going to do aurora yet

we're still producing aurora build, we're just not putting them in the market or advertising them very much because we don't want to spread our testing community too thin.
OS: Linux → All
Hardware: x86 → All
Comment on attachment 529115 [details] [diff] [review]
WIP 1

asking for review. we can update the images as we go.

do you want the appid to be:
ANDROID_PACKAGE_NAME=org.mozilla.fennec_aurora

to kinda follow what we do for beta?
Attachment #529115 - Flags: review?(blassey.bugs)
Comment on attachment 529115 [details] [diff] [review]
WIP 1

Review of attachment 529115 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/branding/aurora/configure.sh
@@ +1,2 @@
> +MOZ_APP_DISPLAYNAME=Aurora
> +ANDROID_PACKAGE_NAME=org.mozilla.aurora

let's go with org.mozilla.fennec_aurora
Attachment #529115 - Flags: review?(blassey.bugs) → review+
Attached patch buildbot configsSplinter Review
This patch adds --with-branding=mobile/branding/aurora  to all */mozilla-aurora/*/mozconfigs 

I had to break the symlinked versions of the mozilla-aurora configs used in the maemo-gtk and maemo-qt folders. Those mozconfigs are real files now, copied from the mobile-browser configs they were symlinked to.
Attachment #530704 - Flags: review?(aki)
Currently testing http://hg.mozilla.org/users/asasaki_mozilla.com/aurora-configs/rev/bbf8efb3045c to make sure that l10n repacks work -- I'll probably just do a linux nightly + repack.
Built a linux mobile desktop nightly to try to trigger repacks, and got

make[5]: *** No rule to make target `/builds/slave/aurora-mob-lnx-ntly/build/mozilla-aurora/mobile/branding/aurora/Makefile.in', needed by `mobile/branding/aurora/Makefile'.  Stop.
Ah looks like the branding patch was pushed to m-c, not mozilla-aurora. Cloning a mozilla-aurora user repo and retrying.
Comment on attachment 530704 [details] [diff] [review]
buildbot configs

r=me if we do the same for the l10n-mozconfig's as well, per
http://hg.mozilla.org/users/asasaki_mozilla.com/aurora-configs/rev/bbf8efb3045c .

(Exporting that, and re-importing doesn't work either. Stupid softlinks.)

Timing: this can land in buildbot-configs default branch at any point, but it'll get merged into the production branch by Tuesday at some point, at which point we need to make sure http://hg.mozilla.org/mozilla-central/rev/34e6f4cc7634 is pushed to mozilla-aurora, or I believe aurora builds will start breaking.

(We've discussed putting the mozconfigs in the tree, which might help, but things like branding might get overwritten during merges. Not sure what the answer is, other than this specific landing needs careful timing.)
Attachment #530704 - Flags: review?(aki) → review+
Comment on attachment 529115 [details] [diff] [review]
WIP 1

We need the aurora branding pushed to mozilla-aurora. RelEng is waiting to land the mozconfig changes until the branding is in place.

Aki did a test build and things seemed to work
Attachment #529115 - Flags: approval-mozilla-aurora?
Attachment #529115 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
pushed to aurora:
http://hg.mozilla.org/releases/mozilla-aurora/rev/1ac7efe85513

We can mark this FIXED when the mozconfigs are landed too
Comment on attachment 530704 [details] [diff] [review]
buildbot configs

Landed on default: http://hg.mozilla.org/build/buildbot-configs/rev/edca67d5e0f0
They will be landed on production tomorrow morning, after which we may want to trigger nightlies.
This is all landed/merged, and Bear kicked off new Aurora nightlies this morning.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Verified fixed on build: Mozilla /5.0 (Android;Linux armv7l;rv:5.0a2) Gecko/20110510 Firefox/5.0a2 Fennec/5.0a2
Status: RESOLVED → VERIFIED
Depends on: 659641
You need to log in before you can comment on or make changes to this bug.