653764 - Edit Tags button no longer offers drop-down autocompletions

Status: VERIFIED FIXED

(developer.mozilla.org Graveyard :: General, defect)

Description

[Eric Shepherd [:sheppy]]

The Edit Tags button at the bottom of the page used to give you a UI that offered autocompletion of tags. Now it brings up the Edit Tags dialog box instead. Can we get that other interface back? It went away with yesterday's MDN 0.9.4 upgrade.

Comment 1

[Craig Cook (:craigcook)]

The tagging interface changed between Mindtouch v9 and v10. I thought the inline ajax editing was done away with entirely, but it turns out it was just moved into a plugin that needs to be called just a bit differently (it was an embedded function in v9). The edit button needs to be placed explicitly in v10 where it was generated automatically by the same function in v9 (this is apparently a known bug in the v10 base skin). The challenge was making sure the same skin code works for the both current v9 wiki and the impending v10 to ensure a smooth upgrade when the time comes to flip the switch.

So the ajax tag editor is resurrected in r88059 and we can include it with 0.9.4.1.

Alas, the v10 interface has completely different markup and a different style, but equivalent functionality. Once the v10 upgrade is live the tagging interface will change with it without any additional skin changes. It looks different but it works in the same way.

Comment 2

[Craig Cook (:craigcook)]

There were some minor changes to the v10 page_tags plugin code itself to eliminate the parentheses that were senselessly hard-coded, so /deki/plugins/page_tags/page_tags.php needs to be deployed as well (it doesn't look like it's included in the automatic SVN update to stage). Until that edit is in place you'll see these annoying "()" in the middle of the tag box.

Note: that plugin file only exists in v10. It should be harmless if the files gets added to a v9 install, but it's essential in v10 to get rid of the parentheses.

Comment 3

[Luke Crouch [:groovecoder]]

0.9.4.1 already launched today so this might have to go to 0.9.4.2?

Comment 4

[Craig Cook (:craigcook)]

Doh! I thought 9.4.1 was next week? Ok, 9.4.2 it shall be...

Comment 5

[Luke Crouch [:groovecoder]]

craig, so is this fixed on stage9? ready for raymond to do QA?

Comment 6

[Craig Cook (:craigcook)]

(In reply to comment #5)
> craig, so is this fixed on stage9? ready for raymond to do QA?

Yeah, sorry. Forgot to change status when I commented.

Comment 7

[raymond [:retornam] (inactive)]

qa-verified https://developer-stage9.mozilla.org/en. There is however a very long delay before the tag added is shown. The same happens when removing a tag

Comment 9

[raymond [:retornam] (inactive)]

verified fixed https://developer.mozilla.org/en

Comment 10

[Craig Cook (:craigcook)]

The file /deki/plugins/page_tags/page_tags.php hasn't been deployed to developer-stage, presumably because the plugins folder isn't included in the auto-update script. It's a small thing, but without the change to that plugin file we'll have annoying empty parentheses in the tags box. 

We'll need to make sure that file gets pushed to prod when the time comes.

Comment 11

[Luke Crouch [:groovecoder]]

Jake,

Can you check that file? (/deki/plugins/page_tags/page_tags.php)

Comment 12

[Jake Maul [:jakem]]

Yep, this plugin is in dekiwiki_mozilla, but not merged into the main dekiwiki. I have symlinked it in place.

ln -s ../../../dekiwiki_mozilla/deki/plugins/page_tags .


dekiwiki/deki/plugins/page_tags -> dekiwiki_mozilla/deki/plugins/page_tags


There is another plugin in dekiwiki_mozilla, called special_page. I can't do the same with it, however, as there is already a special_page directory in the main dekiwiki/deki/plugins dir. If you need anything changed here, please let me know.