653771 - update gitignore to be a bit better

Status: RESOLVED FIXED

(Webtools Graveyard :: Elmo, defect)

Description

[Axel Hecht [:Pike]]

The current gitignore on develop has a bunch of left overs, and doesn't contain *.pyc.

Let's fix that.

Comment 1

[Axel Hecht [:Pike]]

Attachment: update .gitingore

Comment 2

[Axel Hecht [:Pike]]

It's also in https://github.com/Pike/elmo/commit/a4785871192df5081d0f57d2ef406da46a6259b6 to grab.

Comment 3

[Staś Małolepszy :stas]

Comment on attachment 529163 [details] [diff] [review]
update .gitingore

Review of attachment 529163 [details] [diff] [review]:

r=me with a nit, which I'd like to hear your thoughts about.

::: .gitignore
@@ -3,2 @@
 settings/local.py
-settings/test.py

IIRC, test.py was a special settings file the Peter used for faster in-memory tests.  I think it's fine to remove this special case, but I'd change

> settings/local.py

to

> settings/local*.py

so that we can locally have local_test.py, local_bm.py and others if needed.

Comment 4

[Peter Bengtsson [:peterbe]]

(In reply to comment #3)
> flag: review?([e-mail]) => review+Comment on attachment 529163 [details] [diff] [review]
> update .gitingore
> 
> Review of attachment 529163 [details] [diff] [review]:
> 
r=me

> r=me with a nit, which I'd like to hear your thoughts about.
> 
> ::: .gitignore
> @@ -3,2 @@
>  settings/local.py
> -settings/test.py
> 
> IIRC, test.py was a special settings file the Peter used for faster in-memory
> tests.  I think it's fine to remove this special case, but I'd change
> 
> > settings/local.py
> 
> to
> 
> > settings/local*.py
> 
> so that we can locally have local_test.py, local_bm.py and others if needed.

+1


Lastly, I would argue that *.pyc should go into ~/.gitignore_global as it's unreleated to elmo.

Comment 5

[Axel Hecht [:Pike]]

https://github.com/mozilla/elmo/commit/0f0fa903f117ab9505bfb212df3e26a864543581, FIXED.

I prefer to keep *.pyc in there, it's no harm, and it doesn't require that folks contributing need to edit their global git config the way we think they should.

Comment 6

[Staś Małolepszy :stas]

I like the idea of having good defaults straight from a fresh clone, too.