653795 - Naming in the Country Selection dropdown list should be "Taiwan" rather than "Taiwan, Province of China"

Status: VERIFIED FIXED

(Websites Graveyard :: markup.mozilla.org, defect, P3)

Description

[Peter Pin-Guang Chen [:petercpg] (MozTW.org)]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0) Gecko/20100101 Firefox/4.0
Build Identifier: 

Since Mozilla always adopt the political neutral policy, i.e. use "Country/Location" or even only "Location", the country selection dropdown list in Mark Up should list Taiwan as "Taiwan" rather than "Taiwan, Province of China."

Please update the name to "Taiwan", thanks.

Reproducible: Always




Reference: 
https://bugzilla.mozilla.org/show_bug.cgi?id=356038#c23
http://www.freebsd.org/internal/i18n.html

Comment 1

[Po-chiang Chao [:bobchao]]

Dears, the issue is just waste us too much time in many projects around Mozilla, from the very beginning till now. Can we have a guideline of "Standard Country/Area List," and Mozillians can just copy the list in their application?

(We have filed 3+ bugs in different project about the issue.)

Comment 2

[Fred Wenzel [:wenzel]]

That's a good point, absolutely. Where is the country list from?

For the general issue, CCing Potch who had the same problem on glow. How did you solve it there?

Comment 3

[Fred Wenzel [:wenzel]]

Also, confirmed.

Comment 4

[cboardman]

Now changed and will take affect in the next push.

Comment 5

[Matt Brandt [:mbrandt]]

petercpg ~ Thanks for reporting the bug. If you have some time would you verify the patch?

Comment 6

[Peter Pin-Guang Chen [:petercpg] (MozTW.org)]

Sure, but it's not fixed on localizer's stage (https://markup.allizom.org/) yet. Should I watch it somewhere else?  :)

Comment 7

[Gen Kanai [:gen]]

(In reply to comment #1)
> Dears, the issue is just waste us too much time in many projects around
> Mozilla, from the very beginning till now. Can we have a guideline of "Standard
> Country/Area List," and Mozillians can just copy the list in their application?
> 
> (We have filed 3+ bugs in different project about the issue.)

I absolutely agree with Bob here.

Each time this crops up, it's wasted time/effort by everyone involved.  We need our own list of country names to use instead of going to some IANA or ISO list which ends up getting us into this type of bug time after time.

examples include:

https://bugzilla.mozilla.org/show_bug.cgi?id=643088

https://bugzilla.mozilla.org/show_bug.cgi?id=501827

etc.

If we have our own list of countries that WebDev knows to use with all projects, hopefully we won't have to file such bugs again.

Comment 8

[Matt Brandt [:mbrandt]]

Peter: sorry for missing my turn to respond, try https://markup-dev.allizom.org/en-US/. Some username and password as stage.

Comment 9

[Peter Pin-Guang Chen [:petercpg] (MozTW.org)]

(In reply to comment #8)
> Peter: sorry for missing my turn to respond, try
> https://markup-dev.allizom.org/en-US/. Some username and password as stage.

I can login now, but the dropdown list is not showing localized in /zh-TW, and both /en-US and /zh-TW locales are still showing "Taiwan, Province of China."

Comment 10

[Laura Mesa [:lmesa] [:lvmesa]]

Thanks peter!  We'll get this fixed.

Comment 11

[Austin King [:ozten]]

I've fixed this. hz-TW is now 正體中文 (繁體).

This pulls from our standard locale labels via product details JSON blob.

Comment 12

[Peter Pin-Guang Chen [:petercpg] (MozTW.org)]

(In reply to comment #11)
> I've fixed this. hz-TW is now 正體中文 (繁體).
> 
> This pulls from our standard locale labels via product details JSON blob.

Well, the list I'm reporting is not #language-selector but the contents of #country-select and  #markmaker-country.

But "正體中文(繁體)" looks better than "zh-TW" to me on that list though. 

Reopening again and sorry for the confusion. ^^;

Comment 13

[Austin King [:ozten]]

Attachment: Removing Province of China

This comes from assets/js/vendor/country_codes.json

Seems like I can just edit this file, unless this is machine generated code...

Comment 14

[Peter Pin-Guang Chen [:petercpg] (MozTW.org)]

I still couldn't verify this fixed in the dark launch site, when would 1.1 be pushed out?

Comment 15

[Laura Mesa [:lmesa] [:lvmesa]]

1.1 will likely be pushed out a week or so after "launch" on the 17th. It's definitely on the radar.

Comment 16

[Fred Wenzel [:wenzel]]

Austin, has this landed, is this fixed?

Comment 17

[Austin King [:ozten]]

Comment on attachment 531492 [details] [diff] [review]
Removing Province of China

Yes this has been committed and is on -dev, -stage, and production. Sorry I didn't update this bug.

Comment 18

[Peter Pin-Guang Chen [:petercpg] (MozTW.org)]

I can confirm the name fixed on stage and dev now. Thanks guys! :)

Marking this bug as VERIFIED FIXED.

Comment 19

[Gen Kanai [:gen]]

Can we make sure that WebDev does not make this mistake again?  This mistake has been made many, many times (see bug 643088 for one example) and it does not have to happen again if WebDev knows not to go to ISO tables but to our own vetted list of country names. 

I'm not sure what the right process is here but I wanted to raise this before we leave this bug.  We need to make sure we don't make this mistake again. Maybe it's canonical list on a Mozilla wiki?  I'm not sure what will work best.

Comment 20

[Fred Wenzel [:wenzel]]

(In reply to comment #19)
> This mistake
> has been made many, many times (see bug 643088 for one example) and it does
> not have to happen again if WebDev knows not to go to ISO tables but to our
> own vetted list of country names. 

I am completely on board with this. I just don't know if such a canonical list exists yet.

... Now, I just found this:
http://viewvc.svn.mozilla.org/vc/libs/product-details/regions/

Is this what you're referring to? If so, the bug is fixed for posterity (projects just need to use that data). If not, feel free to file a bug for l10n-drivers to come up with a canonical list of countries/regions.