653864 - Design/code/implement 404/500 error pages

Status: VERIFIED FIXED

(Websites Graveyard :: markup.mozilla.org, defect, P1)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

(Yes, this is a blocker for 1.0 -- we can't have pages that just say "404" or "500".)

Splitting off https://bugzilla.mozilla.org/show_bug.cgi?id=652627#c6, we need error pages designed/coded for both the 400* and 500* (and perhaps others?  Fred/Austin?) error pages.

See the current ones at:

https://markup.allizom.org/en-US/fjksl (404)

Looks like 500s in GET/POST methods (submitting data) are handled via an inline message indicating an error, and to restart the process.

Not sure if we need a page for hard 500 errors, like our Oops! messages for when pages won't load at all, due to a critical error on AMO/SUMO, etc.

Comment 1

[Fred Wenzel [:wenzel]]

I'm with Stephen on this one, a 500 error when an unknown URL is entered does not end well.

Food for thought:
https://github.com/fwenzel/reporter/blob/master/templates/404.html
https://github.com/fwenzel/reporter/blob/master/templates/500.html
https://github.com/fwenzel/reporter/blob/master/urls.py#L9

(since Markup does not use jinja templates, might need slightly different syntax there, check with the django docs)

Comment 2

[Chris Hinkle]

As far as design, please use the existing language and visual treatment we have for errors for these pages.

Comment 3

[Adam Miller]

Styled the error pages. 

https://github.com/mozilla/markup/commit/945297d65ae5769ab1a9062c2ee27130e6031471

Comment 4

[Matt Brandt [:mbrandt]]

Attachment: 404 page

Grabbed a screenshot of a 404 message for people to look at. Is this functional enough to get through the 1.0 release?

Comment 5

[Laura Mesa [:lmesa] [:lvmesa]]

Yeah, this will work. 

Thanks!

Comment 6

[Matt Brandt [:mbrandt]]

bumping this to FIXED --> comment 3

Comment 7

[Adam Miller]

that screenshot looks like it was taken with an cached stylesheet. It should be less ugly.

Comment 8

[Matt Brandt [:mbrandt]]

Just cleared my cache and I see the same artifacts. Can you post a screenshot of what you see?

I see this (attachment 529604 [details]) Firefox 4.0.1 on OSX and IE9 on Win7.

Comment 9

[Matt Brandt [:mbrandt]]

Attachment: non-ugly 404 message

Thx Adam (comment 7). Perhaps the new style sheets hadn't percolated down to stage from Github. This is looking great now.

Comment 10

[Matt Brandt [:mbrandt]]

VERIFIED --> comment 9

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Non-ugly 500

For posterity, here's a 500 error.