653871 - Internal Server Error during review submission causes review to be processed but email to be unsent

Status: RESOLVED WORKSFORME

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect, P2)

Description

[Kris Maglione [:kmag]]

User-Agent:       Mozilla/5.0 (X11; Linux x86_64; rv:6.0a1) Gecko/20110419 Firefox/6.0a1
Build Identifier: 

I'm not sure what can be done about this or how often it happens. I only found out by accident when I mentioned an author's review to him.

I submitted the review for the attached URL and got an Internal Server Error page. I reloaded the page to resubmit and got a message that there was no review pending. The review was already in the log from the first submission, but apparently the email never went out.

As there's currently no way for an author to view his past reviews, this is a major issue. It means that for some reviews which we think were successful, the author has no notice of the status of his review, or more importantly, of our feedback. Review submission should either succeed fully or fail fully so that we can re-submit. It shouldn't leave us with a partially processed review and no means to rectify it, or even any knowledge that we need do so.

Reproducible: Sometimes

Comment 1

[Wil Clouser [:clouserw]]

The traceback says:  

>  SMTPServerDisconnected: Connection unexpectedly closed

I assume they had some unexpected downtime, as I've never seen it before.  We can catch this error and log it and try to resend, but it's not something that regularly occurs.

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

Reclassifying editor bugs and changing to a new whiteboard flag. Spam, spam, spam, spam...

Comment 3

[Jorge Villalobos [:jorgev] (he/him)]

This might have been a fluke, or an old bug. Please reopen if it happens again.