Make js_IndexToId not-inline, remove jsxml.cpp:IndexToId

RESOLVED FIXED in mozilla6

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Waldo, Assigned: Waldo)

Tracking

Trunk
mozilla6
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment)

Created attachment 529233 [details] [diff] [review]
Patch

Most of js_IndexToId should be inline, for the common case where the index in question is small.  Also, it most certainly should not duplicate functionality in jsxml.cpp's IndexToId.
Attachment #529233 - Flags: review?(igor)

Comment 1

6 years ago
Comment on attachment 529233 [details] [diff] [review]
Patch

Review of attachment 529233 [details] [diff] [review]:

Nice!
Attachment #529233 - Flags: review?(igor) → review+
http://hg.mozilla.org/tracemonkey/rev/34e8a687ea80
Status: NEW → ASSIGNED
Whiteboard: fixed-in-tracemonkey
Target Milestone: --- → mozilla6

Comment 3

6 years ago
This bug has been fixed on mozilla central, by comments 4 and 5 from bug 653782.
http://hg.mozilla.org/mozilla-central/rev/34e8a687ea80
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.