Last Comment Bug 653872 - Make js_IndexToId not-inline, remove jsxml.cpp:IndexToId
: Make js_IndexToId not-inline, remove jsxml.cpp:IndexToId
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
-- normal (vote)
: mozilla6
Assigned To: Jeff Walden [:Waldo] (remove +bmo to email)
: Jason Orendorff [:jorendorff]
Depends on:
  Show dependency treegraph
Reported: 2011-04-29 16:34 PDT by Jeff Walden [:Waldo] (remove +bmo to email)
Modified: 2011-06-21 10:20 PDT (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch (4.48 KB, patch)
2011-04-29 16:34 PDT, Jeff Walden [:Waldo] (remove +bmo to email)
igor: review+
Details | Diff | Splinter Review

Description User image Jeff Walden [:Waldo] (remove +bmo to email) 2011-04-29 16:34:22 PDT
Created attachment 529233 [details] [diff] [review]

Most of js_IndexToId should be inline, for the common case where the index in question is small.  Also, it most certainly should not duplicate functionality in jsxml.cpp's IndexToId.
Comment 1 User image Igor Bukanov 2011-04-29 16:57:08 PDT
Comment on attachment 529233 [details] [diff] [review]

Review of attachment 529233 [details] [diff] [review]:

Comment 2 User image Jeff Walden [:Waldo] (remove +bmo to email) 2011-05-04 21:34:19 PDT
Comment 3 User image Guilherme Lima 2011-05-11 14:31:30 PDT
This bug has been fixed on mozilla central, by comments 4 and 5 from bug 653782.
Comment 4 User image :Ms2ger (⌚ UTC+1/+2) 2011-06-21 10:20:21 PDT

Note You need to log in before you can comment on or make changes to this bug.