Unable to access a few files via file viewer

VERIFIED FIXED in 6.0.9

Status

P5
normal
VERIFIED FIXED
8 years ago
3 years ago

People

(Reporter: krupa.mozbugs, Assigned: andy+bugzilla)

Tracking

unspecified
6.0.9

Details

(URL)

(Reporter)

Description

8 years ago
steps to reproduce:
1.  Load https://addons.allizom.org/en-US/firefox/files/browse/116448/

expected behavior:
Contents of the add-on loads

observed behavior:
Contents don't load. Error message 'There was an error accessing file 116448.' is displayed.

Apr 29 16:26:46 pm-gearman-amo02.mozilla.org: [<anon>][None] z.task:ERROR Error (File is not a zip file) extracting /mnt/netapp_amo/addons.mozilla.org-preview/files/302220/mobile_only_add_on234-1.1-fn-mac.xpi :/data/amo_python/www/preview/zamboni/apps/files/helpers.py:84
(Assignee)

Comment 1

8 years ago
Downloaded file and ran it locally and it works fine. Why it thinks its not a zip file, i'm not sure yet.
Could be corrupt?  I can poke at it if you want.  Let me know how I can help.
Assignee: nobody → amckay
Priority: -- → P5
I tried opening this file on the machine and it worked fine.  I guess next step is to write a minimal test case and see if it's the python lib - `unzip` on disk is fine.
(Assignee)

Comment 4

8 years ago
Unzip's via python libs locally and on khan too.
(Assignee)

Comment 5

8 years ago
  File "/data/amo_python/www/preview/zamboni/apps/files/helpers.py", line 84, in extract
    extract_xpi(self.src, self.dest, expand=True)

  File "/data/amo_python/www/preview/zamboni/apps/files/utils.py", line 184, in extract_xpi
    dest = extract_zip(src, remove=True)

  File "/data/amo_python/www/preview/zamboni/apps/files/utils.py", line 141, in extract_zip
    zip = zipfile.ZipFile(source)

  File "/data/amo_python/www/preview/zamboni/vendor/lib/python/zipfile.py", line 693, in __init__
    self._GetContents()

  File "/data/amo_python/www/preview/zamboni/vendor/lib/python/zipfile.py", line 713, in _GetContents
    self._RealGetContents()

  File "/data/amo_python/www/preview/zamboni/vendor/lib/python/zipfile.py", line 725, in _RealGetContents
    raise BadZipfile, "File is not 

It's using the zipfile.py added in vendor, which is probably a good thing.
(Assignee)

Comment 6

8 years ago
https://github.com/jbalogh/zamboni/commit/b0168f5c8f31867d0795f850e9d674fed3e0f010
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Reporter)

Comment 7

8 years ago
verified fixed @ https://addons.allizom.org/en-US/firefox/files/browse/116448/#file-viewer

If there is trouble accessing other files, that will be tracked as new bugs.
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.