653888 - JSON Walk algorithm should be able to delete properties from parsed arrays

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jeff Walden [:Waldo]]

Attachment: Patch with test

Was doing a last bit of cleanup here since most of the rest of the code is well-examined for spec compliance issues, turns out there's a little bit to go still -- good thing I looked.

Comment 1

[Paul Biggar]

Comment on attachment 529258 [details] [diff] [review]
Patch with test

Review of attachment 529258 [details] [diff] [review]:

The only comment I'd have here is that it would be good to use variable names from the spec, like 'val' and 'keys'.

Comment 2

[Paul Biggar]

Oh, and I forgot to say, this didn't apply for me, so I havent checked that this works.

Comment 3

[Jeff Walden [:Waldo]]

Nope, it's atop a bunch of other patches locally (some of which you just reviewed).  That's not uncommon; in general, if you want something to test and the patch doesn't work, ping me on IRC for a patch bundle.

Comment 4

[Chris Leary [:cdleary] (not checking bugmail)]

cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/83ae6e7c572e
http://hg.mozilla.org/mozilla-central/rev/50fe7f87c01a (backout)
Note: not marking as fixed because last changeset is a backout.

Comment 5

[Jeff Walden [:Waldo]]

http://hg.mozilla.org/tracemonkey/rev/3ba391aa3130

Comment 6

[Chris Leary [:cdleary] (not checking bugmail)]

cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/3ba391aa3130

Comment 7

[Jeff Walden [:Waldo]]

Per comment 6 (bot bug?).