The default bug view has changed. See this FAQ.

JSON Walk algorithm should be able to delete properties from parsed arrays

RESOLVED FIXED in mozilla6

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Waldo, Assigned: Waldo)

Tracking

Trunk
mozilla6
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-tracemonkey, URL)

Attachments

(1 attachment)

Created attachment 529258 [details] [diff] [review]
Patch with test

Was doing a last bit of cleanup here since most of the rest of the code is well-examined for spec compliance issues, turns out there's a little bit to go still -- good thing I looked.
Attachment #529258 - Flags: review?(pbiggar)

Comment 1

6 years ago
Comment on attachment 529258 [details] [diff] [review]
Patch with test

Review of attachment 529258 [details] [diff] [review]:

The only comment I'd have here is that it would be good to use variable names from the spec, like 'val' and 'keys'.
Attachment #529258 - Flags: review?(pbiggar) → review+

Comment 2

6 years ago
Oh, and I forgot to say, this didn't apply for me, so I havent checked that this works.
Nope, it's atop a bunch of other patches locally (some of which you just reviewed).  That's not uncommon; in general, if you want something to test and the patch doesn't work, ping me on IRC for a patch bundle.
cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/83ae6e7c572e
http://hg.mozilla.org/mozilla-central/rev/50fe7f87c01a (backout)
Note: not marking as fixed because last changeset is a backout.
http://hg.mozilla.org/tracemonkey/rev/3ba391aa3130
Whiteboard: fixed-in-tracemonkey
cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/3ba391aa3130
Per comment 6 (bot bug?).
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.