Closed Bug 654226 Opened 14 years ago Closed 14 years ago

Validation of older versions fail with a 500

Categories

(addons.mozilla.org Graveyard :: Developer Pages, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: krupa.mozbugs, Assigned: kumar)

References

()

Details

(Keywords: regression)

steps to reproduce: 1. Load https://addons.mozilla.org/en-US/developers/addon/delicious-bookmarks/file/67323/validation observed behavior: validation fails with internal server error Request Headers: Host: addons.mozilla.org User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0.1) Gecko/20100101 Firefox/4.0.1 Accept: application/json, text/javascript, */* Accept-Language: en-us,en;q=0.5 Accept-Encoding: gzip, deflate Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.7 Keep-Alive: 115 Connection: keep-alive X-Requested-With: XMLHttpRequest Referer: https://addons.mozilla.org/en-US/developers/addon/delicious-bookmarks/file/67323/validation Content-Length: 0 Content-Type: text/plain; charset=UTF-8 Cookie: WT_FPC=id=29d4568d25191498dd21304357511301:lv=1304365305649:ss=1304365294062; wtspl=342647; amo_home_promo_seen=2; AMOv3=88j2cakcprnml8oc2cvv8jbhh1; AMOappName=firefox; sessionid=e86e49ca0d313a51eab46b0efaafd6bd Pragma: no-cache Cache-Control: no-cache Response Headers: Server: Apache Vary: X-Mobile, Accept-Encoding X-Backend-Server: pm-app-amo02 Cache-Control: no-cache Content-Type: text/html; charset=UTF-8 X-amo-darklaunch: z Content-Encoding: gzip Date: Mon, 02 May 2011 20:41:45 GMT Keep-Alive: timeout=5, max=1000 Transfer-Encoding: chunked x-content-security-policy-report-only: policy-uri /services/csp/policy Via: Moz-Cache-pm-zlb-amo03 Connection: Keep-Alive Set-Cookie: multidb_pin_writes=y; expires=Mon, 02-May-2011 20:42:00 GMT; Max-Age=15; Path=/ X-Frame-Options: DENY
=> kumar because I think you're familiar with this code. Let me know if you have csrf questions.
Assignee: nobody → kumar.mcmillan
(In reply to comment #0) > steps to reproduce: > 1. Load > https://addons.mozilla.org/en-US/developers/addon/delicious-bookmarks/file/67323/validation > > observed behavior: > validation fails with internal server error I can't reproduce this. The page is fine and I see a 200 response for this POST in the log: [11:36:42.183] POST https://addons.mozilla.org/en-US/developers/addon/delicious-bookmarks/file/67323/validation.json [HTTP/1.1 200 OK 2346ms] Can you send the JSON output of that request?
Now, I'm hitting 500s when I tried to validate an older version of an add-on. Load https://addons.mozilla.org/en-US/developers/addon/delicious-bookmarks/versions/ Click on 'Validate now' link for a version which hasn't been previously validated. [09:51:16.280] POST https://addons.mozilla.org/en-US/developers/addon/delicious-bookmarks/file/31284/validation.json [HTTP/1.1 500 Internal Server Error 31734ms] Once the 500s are resolved, I'll try reproducing the CSRF error.
Summary: Validation of older versions fail due to 403(CSRF verification failure) → Validation of older versions fail with a 500
It seems that the view was not CSRF exempt (as it should be) and something changed on the server that now intercepts all posts? That's my best guess. After this, it's working for me: https://github.com/jbalogh/zamboni/commit/2d36a61fd30009ae80fc77a586245249efe8c568
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
I'll mark this verified after checking in prod.
This has been cherry-picked to next
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.