Closed
Bug 654288
Opened 15 years ago
Closed 15 years ago
remove "using namespace avmplus" from shell .h files
Categories
(Tamarin Graveyard :: Virtual Machine, defect)
Tamarin Graveyard
Virtual Machine
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: stejohns, Unassigned)
Details
Attachments
(1 file)
|
432.32 KB,
patch
|
rreitmai
:
review+
|
Details | Diff | Splinter Review |
There are a couple of avmshell header files that do "using namespace avmplus", which is (1) bad form and (2) will slightly complicate some ANI work down the Road. We should remove these and explicitly add avmplus:: where necessary.
Attachment #529581 -
Flags: review?(rreitmai)
|
||
Comment 1•15 years ago
|
||
Comment on attachment 529581 [details] [diff] [review]
Patch
r+ rubber stamp assuming this is only search and replace; let me know if I should be looking at anything deeper.
Attachment #529581 -
Flags: review?(rreitmai) → review+
|
|
Reporter | |
Comment 2•15 years ago
|
||
TR 6257:58d0a2116188
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
|
||
Comment 3•15 years ago
|
||
changeset: 6258:0ee91619d908
user: Steven Johnson <stejohns@adobe.com>
summary: Bug 654288 followup: Windows-specific fixes
http://hg.mozilla.org/tamarin-redux/rev/0ee91619d908
You need to log in
before you can comment on or make changes to this bug.
Description
•