unneeded saving of filter files during folder move/copies slows the process

RESOLVED FIXED in Thunderbird 5.0b1

Status

MailNews Core
Filters
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Bienvenu, Assigned: Bienvenu)

Tracking

({perf})

Trunk
Thunderbird 5.0b1
x86
Windows 7

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
Created attachment 529597 [details] [diff] [review]
proposed fix

I was deleting a local folder hierarchy, and it was taking forever. Using my top-secret performance investigation technique, I discovered that we were spending most of the time saving the filter list unnecessarily. Fix upcoming.

Asking for review from rkent on the slightly dubious basis that this nominally involves filters.
Attachment #529597 - Flags: review?(kent)
(Assignee)

Comment 1

7 years ago
Created attachment 529607 [details] [diff] [review]
make sure we set found
Attachment #529597 - Attachment is obsolete: true
Attachment #529597 - Flags: review?(kent)
Attachment #529607 - Flags: review?(kent)

Updated

7 years ago
Keywords: perf
Summary: unneeded saving of filter files during folder move/copies → unneeded saving of filter files during folder move/copies slows the process

Comment 2

7 years ago
Comment on attachment 529607 [details] [diff] [review]
make sure we set found

Review of attachment 529607 [details] [diff] [review]:

The essence of this is "check found value not address", not "make sure we set found" as the found are already all set upstream AFAICT, but no matter, the patch is good.
Attachment #529607 - Flags: review?(kent) → review+
(Assignee)

Comment 3

7 years ago
fixed on trunk - http://hg.mozilla.org/comm-central/rev/7e6e9dc6e84d

the name of the second patch was trying to describe the difference between the first and second patch, which is that we need to set *found to PR_FALSE when we don't find a matching filter, instead of only setting it to PR_TRUE when we do find a filter.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.3a4
You need to log in before you can comment on or make changes to this bug.