654412 - Hudson build script for running tests

Status: RESOLVED FIXED

(Webtools Graveyard :: Elmo, defect)

Description

[Peter Bengtsson [:peterbe]]

We need a build script for Hudson. That sets up a virtualenv, pulls down all code and runs all relevant tests.

Comment 1

[Peter Bengtsson [:peterbe]]

Attachment: First working attempt

This is taken from having manually typed in a build script in the Hudson configure textarea. There are still some ugly edges and question marks I'd like to iron out. Hence having a bug about it.

Comment 2

[Axel Hecht [:Pike]]

Comment on attachment 529684 [details] [diff] [review]
First working attempt

Review of attachment 529684 [details] [diff] [review]:

::: scripts/build.sh
@@ +7,5 @@
+
+
+find . -name '*.pyc' -delete;
+
+virtualenv elmo_env

should we make this a --no-site-packages ?

@@ +41,5 @@
+pip install -q MySQL-python==1.2.3c1
+pip install -q mercurial
+pip install -q hmac==20101005
+pip install -q hashlib==20081119
+pip install -q py-bcrypt==0.2

do we need to specify the virtualenv here? I just had an odd experience with pip not doing that by default, IIRC. Can't hurt to have it, I guess.

Comment 3

[Axel Hecht [:Pike]]

Technical jargon: doing review comments without setting the review flag to either + or - means that the r+ or - depends on the answers on the questions still.

Comment 4

[Peter Bengtsson [:peterbe]]

(In reply to comment #2)
> Comment on attachment 529684 [details] [diff] [review] [review]
> First working attempt
> 
> Review of attachment 529684 [details] [diff] [review] [review]:
> 
> ::: scripts/build.sh
> @@ +7,5 @@
> +
> +
> +find . -name '*.pyc' -delete;
> +
> +virtualenv elmo_env
> 
> should we make this a --no-site-packages ?
> 
Fixed and tested. Still works. 

> @@ +41,5 @@
> +pip install -q MySQL-python==1.2.3c1
> +pip install -q mercurial
> +pip install -q hmac==20101005
> +pip install -q hashlib==20081119
> +pip install -q py-bcrypt==0.2
> 
> do we need to specify the virtualenv here? I just had an odd experience with
> pip not doing that by default, IIRC. Can't hurt to have it, I guess.

? I don't understand. 

The reason I don't do something like `pip install -r requirements/foo.txt` is because of a problem with building python-ldap and the fact that we strangely still have django in requirements/prod.txt.

Comment 5

[Axel Hecht [:Pike]]

(In reply to comment #4)
> (In reply to comment #2)
<...>
> > @@ +41,5 @@
> > +pip install -q MySQL-python==1.2.3c1
> > +pip install -q mercurial
> > +pip install -q hmac==20101005
> > +pip install -q hashlib==20081119
> > +pip install -q py-bcrypt==0.2
> > 
> > do we need to specify the virtualenv here? I just had an odd experience with
> > pip not doing that by default, IIRC. Can't hurt to have it, I guess.
> 
> ? I don't understand. 
> 
> The reason I don't do something like `pip install -r requirements/foo.txt` is
> because of a problem with building python-ldap and the fact that we strangely
> still have django in requirements/prod.txt.

I was thinking about

pip install -E elmo_env -q ...

Comment 6

[Axel Hecht [:Pike]]

Comment on attachment 529684 [details] [diff] [review]
First working attempt

one final nit, 
\ No newline at end of file

I'm awkward with those.

Comment 7

[Axel Hecht [:Pike]]

carrying over from irc, the -E stuff shouldn't be needed, can't reproduce the problems I had without that.

Comment 8

[Peter Bengtsson [:peterbe]]

Pushed. 

(need to look for a pre-commit hook that checks for lacking newline endings)