Closed Bug 654423 Opened 9 years ago Closed 8 years ago

Intermittent TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug630102.js | application timed out

Categories

(Firefox Graveyard :: Panorama, defect)

All
Windows XP
defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 7

People

(Reporter: glandium, Assigned: ttaubert)

Details

Attachments

(1 file, 1 obsolete file)

TEST-START | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug630102.js
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug630102.js | application timed out after 330 seconds with no output
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1304420117.1304421438.20710.gz
Component: Tabbed Browser → Panorama
QA Contact: tabbed.browser → panorama
Assignee: nobody → tim.taubert
Status: NEW → ASSIGNED
Attached patch patch v1 (obsolete) — Splinter Review
Attachment #529800 - Flags: review?(ehsan)
So, what is the fix here?  I can't figure out which problem you're trying to fix here, and how...
(In reply to comment #2)
> So, what is the fix here?  I can't figure out which problem you're trying to
> fix here, and how...

Sorry, I should have explained that a bit:

>  window.addEventListener("tabviewshown", partOne, false);
>  TabView.toggle();

That is the part that should start the test but doesn't if tabview is still or already shown. So I replaced all of these occurrences with the head.js functions showTabView() and hideTabView() that are more robust and just continue if the tabview is already shown/hidden.

The rest is just cleanup according to our current style of writing tests.
Attachment #529800 - Flags: review?(ehsan) → review+
Attachment #529800 - Attachment is obsolete: true
Keywords: checkin-needed
Whiteboard: [fixed in cedar]
Version: unspecified → Trunk
http://hg.mozilla.org/mozilla-central/rev/de21696c8853
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Whiteboard: [fixed in cedar]
Target Milestone: --- → Firefox 6
Backed out from m-c on suspicion of causing browser/base/content/test/tabview/browser_tabview_bug597248.js test timeout permaorange.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
http://hg.mozilla.org/integration/mozilla-inbound/rev/f5a456d99df9
Whiteboard: [inbound]
Target Milestone: Firefox 6 → ---
Backed out due to mochitest-other orange.
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/0c47cb07f689
Status: REOPENED → RESOLVED
Closed: 9 years ago8 years ago
Flags: in-testsuite? → in-testsuite+
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → Firefox 7
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.