654423 - Intermittent TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug630102.js | application timed out

Status: VERIFIED FIXED

(Firefox Graveyard :: Panorama, defect)

Description

[Mike Hommey [:glandium]]

TEST-START | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug630102.js
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug630102.js | application timed out after 330 seconds with no output
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1304420117.1304421438.20710.gz

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v1

Comment 2

[(no longer active)]

So, what is the fix here?  I can't figure out which problem you're trying to fix here, and how...

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

(In reply to comment #2)
> So, what is the fix here?  I can't figure out which problem you're trying to
> fix here, and how...

Sorry, I should have explained that a bit:

>  window.addEventListener("tabviewshown", partOne, false);
>  TabView.toggle();

That is the part that should start the test but doesn't if tabview is still or already shown. So I replaced all of these occurrences with the head.js functions showTabView() and hideTabView() that are more robust and just continue if the tabview is already shown/hidden.

The rest is just cleanup according to our current style of writing tests.

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 529800 [details] [diff] [review]
patch v1

Passed try:

http://tbpl.mozilla.org/?tree=Try&pusher=[e-mail]&rev=a69993664cb1

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch for checkin

Comment 6

[Boris Zbarsky [:bzbarsky]]

http://hg.mozilla.org/mozilla-central/rev/de21696c8853

Comment 7

[Boris Zbarsky [:bzbarsky]]

Backed out from m-c on suspicion of causing browser/base/content/test/tabview/browser_tabview_bug597248.js test timeout permaorange.

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/f5a456d99df9

Comment 9

[Boris Zbarsky [:bzbarsky]]

Backed out due to mochitest-other orange.

Comment 10

[Tim Taubert [:ttaubert] (inactive)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/0c47cb07f689

Comment 11

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/0c47cb07f689

Comment 12

[Virgil Dicu [:virgil] [QA]]

Verified fixed based on results in:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1314762663.1314767018.2727.gz&fulltext=1