TEST-START | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug630102.js TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug630102.js | application timed out after 330 seconds with no output http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1304420117.1304421438.20710.gz
Created attachment 529800 [details] [diff] [review] patch v1
So, what is the fix here? I can't figure out which problem you're trying to fix here, and how...
(In reply to comment #2) > So, what is the fix here? I can't figure out which problem you're trying to > fix here, and how... Sorry, I should have explained that a bit: > window.addEventListener("tabviewshown", partOne, false); > TabView.toggle(); That is the part that should start the test but doesn't if tabview is still or already shown. So I replaced all of these occurrences with the head.js functions showTabView() and hideTabView() that are more robust and just continue if the tabview is already shown/hidden. The rest is just cleanup according to our current style of writing tests.
Comment on attachment 529800 [details] [diff] [review] patch v1 Passed try: http://tbpl.mozilla.org/?tree=Tryemail@example.com&rev=a69993664cb1
Created attachment 529857 [details] [diff] [review] patch for checkin
Backed out from m-c on suspicion of causing browser/base/content/test/tabview/browser_tabview_bug597248.js test timeout permaorange.
Backed out due to mochitest-other orange.
Verified fixed based on results in: http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1314762663.1314767018.2727.gz&fulltext=1