Only include URL of active tab in content crash reports

RESOLVED FIXED

Status

RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: ted, Assigned: blassey)

Tracking

Details

Attachments

(1 attachment)

+++ This bug was initially created as a clone of Bug #654312 +++

The patch in bug 654312 sends the URLs of all tabs with content crash reports. This is bad, and we shouldn't do this.

a) We explicitly rejected this as too invasive of users' privacy when we designed desktop crash reporting. Yes, it might be useful, but we have to respect our users and this is just too much information.
b) Our infrastructure only expects a single URL in the URL field anyway, so topcrash by URL reports etc won't work properly with this data.

We should just send the URL of the active tab. On desktop we try to be smart about load events etc, and save the most recently active tab, or something like that. It's always going to be imprecise, but it's the right thing to do.
Created attachment 529722 [details] [diff] [review]
patch
Assignee: nobody → blassey.bugs
Attachment #529722 - Flags: review?(mark.finkle)
Comment on attachment 529722 [details] [diff] [review]
patch

I don't like accessing __SS_data, but we need to refactor the nsISessionStroe interface to fix that. Of course, this code should be removed as soon as the crashreporter annotations work for the child crashes.
Attachment #529722 - Flags: review?(mark.finkle) → review+
pushed http://hg.mozilla.org/mozilla-central/rev/0a0081de66e3
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED

Comment 4

7 years ago
Can someone please verify this bug ?
You need to log in before you can comment on or make changes to this bug.