65446 - PSM builds using gmake, needs to be make on Linux

Status: VERIFIED DUPLICATE of bug 63832

(Core :: Security: PSM, defect)

Description

[James Green]

A default mozilla pull and build works fine here. I pulled this evening using
the following:

make -f client.mk checkout BUILD_MODULES=psm && make -f client.mk build && make
-f client.mk build BUILD_MODULES=psm

which was suggested by someone. It pulled fine and was compiling, until the
following exit error occurred:

if test ! -d /usr/src/cvs/mozilla/obj-opt/security/psm/doc; then       \
        cp -r /usr/src/cvs/mozilla/mozilla/security/psm/doc
/usr/src/cvs/mozilla/obj-opt/security/psm/; \
fi;
cd /usr/src/cvs/mozilla/obj-opt/security/coreconf; gmake -f Makefile BUILD_OPT=1
 DIST=/usr/src/cvs/mozilla/obj-opt/dist/Linux2.4_x86_glibc_PTH_OPT.OBJ 
SOURCE_LIB_DIR=/usr/src/cvs/mozilla/obj-opt/dist/Linux2.4_x86_glibc_PTH_OPT.OBJ/lib
SOURCE_BIN_DIR=/usr/src/cvs/mozilla/obj-opt/dist/Linux2.4_x86_glibc_PTH_OPT.OBJ/bin
SOURCE_XP_DIR=/usr/src/cvs/mozilla/obj-opt/dist/Linux2.4_x86_glibc_PTH_OPT.OBJ
/bin/sh: gmake: command not found
make[3]: *** [install] Error 127
make[3]: Leaving directory `/usr/src/cvs/mozilla/obj-opt/security/psm'
make[2]: *** [install] Error 2
make[2]: Leaving directory `/usr/src/cvs/mozilla/obj-opt/security'
make[1]: *** [install] Error 2
make[1]: Leaving directory `/usr/src/cvs/mozilla/obj-opt'
make: *** [build] Error 2

Clearly something is using 'gmake' rather than 'make' here, which of course
doesn't work.

Comment 1

[James Green]

Easy workaround for this. ln -s /usr/bin/make /usr/bin/gmake. Quite whether
there are any differences between the two isn't clear to me at least, however it
builds and seems to work fine with https://hotmail.com. Marking this severity
Major as it will block people who aren't aware of this simple symlink workaround.

Comment 2

[cls]

All PSM builds need to be assigned to the PSM product.

Comment 3

[cls]

ddrinan's on sabbatical.

Comment 4

[Stephan Niemz]

I ran into this before, too.

Of course you can always symlink make to gmake, but that's an ugly workaround,
not a solution.

A makefile should *always* use $(MAKE) to invoke another make process, not make
or gmake or whatevermake. That variable contains the exact name you want, namely
the name by which the currently running make was invoked.

I think that can't be hard to fix: find -name Mak\* | xargs grep -n gmake

Comment 5

[Stephan Niemz]

Seems like there is already a bug about this and something checked in.

*** This bug has been marked as a duplicate of 63832 ***

Comment 6

[Diego]

Verified dupe of bug 63832: "Makefile.in files have gmake hard coded"