654587 - addon validator says versions are not in correct order

Status: RESOLVED INVALID

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Kumar McMillan [:kumar]]

Attachment: xpi with max version 4.0.*

I was expecting this validation to run a successful no-op validation, instead I got: "The version numbers provided for the application in question are not in the correct order. The maximum version must be greater than the minimum version.", "\"4.0b4\" is not less than \"4.0b1\"."

Any ideas?

STR
1. Edit validate.py temporarily with this: for_appversions = {'{ec8030f7-c20a-464f-9b0e-13a3a9e97384}': ["5.0a2"]}
2. Download attached xpi and run python addon-validator -o json desktop-and-mobile-3.xpi

The max version of the xpi is 4.0.* so this should work, right?

This is using amo-validator's built-in app_versions.json and the same error happens using AMO's database of app versions.


My full results:

{
    "errors": 0,
    "detected_type": "extension",
    "success": false,
    "warnings": 1,
    "notices": 0,
    "message_tree": {
        "testcases_targetapplication": {
            "__messages": [],
            "__warnings": 1,
            "__errors": 0,
            "__notices": 0,
            "test_targetedapplications": {
                "invalid_version_order": {
                    "__messages": ["0fc4c7555eb84a68ae536a4b0a97e194"],
                    "__warnings": 1,
                    "__errors": 0,
                    "__notices": 0
                },
                "__messages": [],
                "__warnings": 1,
                "__errors": 0,
                "__notices": 0
            }
        }
    },
    "ending_tier": 5,
    "messages": [{
        "description": ["The version numbers provided for the application in question are not in the correct order. The maximum version must be greater than the minimum version.", "\"4.0b4\" is not less than \"4.0b1\"."],
        "file": "install.rdf",
        "tier": 1,
        "message": "Invalid min/max versions",
        "line": null,
        "uid": "0fc4c7555eb84a68ae536a4b0a97e194",
        "column": null,
        "id": ["testcases_targetapplication", "test_targetedapplications", "invalid_version_order"],
        "context": null,
        "for_appversions": null,
        "type": "warning"
    }],
    "metadata": {
        "version": "3.0",
        "name": "Desktop And Mobile 3",
        "id": "[e-mail]"
    }
}

Comment 1

[Matt Basta [:basta]]

Correct me if I'm wrong, but the error output is correct, isn't it? Your targetApplication for Firefox Mobile is as follows:

    <em:targetApplication>
      <Description>
        <em:id>{a23983c0-fd0e-11dc-95ff-0800200c9a66}</em:id> <!-- Mobile -->
        <em:minVersion>4.0b4</em:minVersion>
        <em:maxVersion>4.0b1</em:maxVersion>
      </Description>

4.0b1 is indeed an earlier version that 4.0b4, correct?

Comment 2

[Kumar McMillan [:kumar]]

(In reply to comment #1)
> Correct me if I'm wrong, but the error output is correct, isn't it? Your
> targetApplication for Firefox Mobile is as follows:

Ah!  thanks.  I was confused because the error message did not say what app the version mismatch was for and I wasn't looking at the mobile section.  Just needed another pair of eyes.



> 
>     <em:targetApplication>
>       <Description>
>         <em:id>{a23983c0-fd0e-11dc-95ff-0800200c9a66}</em:id> <!-- Mobile -->
>         <em:minVersion>4.0b4</em:minVersion>
>         <em:maxVersion>4.0b1</em:maxVersion>
>       </Description>
> 
> 4.0b1 is indeed an earlier version that 4.0b4, correct?