The default bug view has changed. See this FAQ.

cannot use copy and paste keyboard shortcuts in panorama

VERIFIED FIXED in Firefox 7

Status

Firefox Graveyard
Panorama
VERIFIED FIXED
6 years ago
a year ago

People

(Reporter: tinagma, Assigned: raymondlee)

Tracking

({regression})

Trunk
Firefox 7
x86
All
regression
Dependency tree / graph

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

6 years ago
User-Agent:       Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:6.0a1) Gecko/20110429 Firefox/6.0a1
Build Identifier: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:6.0a1) Gecko/20110429 Firefox/6.0a1

When trying to cut, copy, or paste to the titles in panorama using the shortcut keys, nothing happens. I can do it just fine using menu commands, but this is different from the entire rest of the browser.

Reproducible: Always

Steps to Reproduce:
1.open panorama
2.name a tab group
3.select the tab title
4.press cmd-x

Actual Results:  
nothing happens

Expected Results:  
the text should be removed and placed on the clipboard
(Reporter)

Updated

6 years ago
Version: unspecified → Trunk
(Reporter)

Updated

6 years ago
OS: Mac OS X → All
Blocks: 653099
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Reporter)

Comment 1

6 years ago
note: nothing happens when cmd-c or cmd-v is tried, either.

Comment 2

6 years ago
Regression window(m-c hourly):
Works:
http://hg.mozilla.org/mozilla-central/rev/76fbb32b78af
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.2a1pre) Gecko/20110331 Firefox/4.2a1pre ID:20110331104953
Fails:
http://hg.mozilla.org/mozilla-central/rev/e38b294f02c5
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.2a1pre) Gecko/20110331 Firefox/4.2a1pre ID:20110331125525
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=76fbb32b78af&tochange=e38b294f02c5
Suspected:
565c588e3e51	Raymond Lee — Bug 587276 - KeyEvent in TabCandy window affect browser [r=ian]
Blocks: 587276
Keywords: regression

Updated

6 years ago
tracking-firefox5: --- → ?
(Assignee)

Comment 3

6 years ago
Created attachment 529930 [details] [diff] [review]
v1

Re-enable cut, copy, paste, undo, redo and selectAll
Assignee: nobody → raymond
Status: NEW → ASSIGNED
Attachment #529930 - Flags: feedback?(tim.taubert)
Comment on attachment 529930 [details] [diff] [review]
v1

Review of attachment 529930 [details] [diff] [review]:

Looks good. The only thing I don't like (about the solution in general) is that we can't allow shortcuts that have no associated command like (Ctrl+BackSpace, Ctrl+Left, Ctrl+Right, etc.). But seems there is no way to integrate them with our current white list implementation.
Attachment #529930 - Flags: feedback?(tim.taubert) → feedback+
(Assignee)

Updated

6 years ago
Attachment #529930 - Flags: review?(ian)
This goes on the tracking list for FF5.

Can I get a risk assessment: should we be fixing this on aurora, or backing out the change that caused it?
tracking-firefox5: ? → +
(In reply to comment #5)
> Can I get a risk assessment: should we be fixing this on aurora, or backing out
> the change that caused it?

The risk of this patch is really low as it only adds some new commands to the white list. It re-enables cut, copy, paste, undo, redo and selectAll but not [Ctrl+BackSpace/Left/Right]. So if the latter ones are really important we might have to back out.
Comment on attachment 529930 [details] [diff] [review]
v1

Review of attachment 529930 [details] [diff] [review]:

I agree with Tim; it would be good to support those additional shortcuts. The patch as is is a good fix, though; maybe file a follow up?
Attachment #529930 - Flags: review?(ian) → review+
(Assignee)

Comment 8

6 years ago
(In reply to comment #7)
> Comment on attachment 529930 [details] [diff] [review] [review]
> v1
> 
> Review of attachment 529930 [details] [diff] [review] [review]:
> 
> I agree with Tim; it would be good to support those additional shortcuts. The
> patch as is is a good fix, though; maybe file a follow up?

I am working on a patch for bug 621795 which should also fix this bug.  I suggest to put this patch on hold for now.
is this the bug that would cover not being able to paste anything into the find-field of panorama or would that require a new bug ?
(In reply to comment #9)
> is this the bug that would cover not being able to paste anything into the
> find-field of panorama or would that require a new bug ?

I think we can handle this here as the patch will very likely fix this, too.

Comment 11

6 years ago
What we have here is a reviewed fix in hand that covers a good subset of the problem case. Over in bug 621795 we don't have a reviewed patch and what's there seems considerably more involved. 

We should either take this patch into Beta (in which case, can one of you please nominate it with approval-mozilla-beta?) or we should re-visit backing out what ever change caused this regression. (What change was that?)
(Assignee)

Comment 12

6 years ago
Created attachment 533544 [details] [diff] [review]
Patch for checkin

Submitted to try and waiting for the result.
http://tbpl.mozilla.org/?tree=Try&rev=15939812e38d
Attachment #533544 - Flags: approval-mozilla-beta?
(Assignee)

Updated

6 years ago
Attachment #529930 - Attachment is obsolete: true
(Assignee)

Comment 13

6 years ago
(In reply to comment #12)
> Created attachment 533544 [details] [diff] [review] [review]
> Patch for checkin
> 
> Submitted to try and waiting for the result.
> http://tbpl.mozilla.org/?tree=Try&rev=15939812e38d

Passed Try!

Updated

6 years ago
Attachment #533544 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment 14

6 years ago
Comment on attachment 533544 [details] [diff] [review]
Patch for checkin

Please land this change on both Aurora and Beta. (In the future, getting changes in during Aurora will save you this extra step.)
Attachment #533544 - Flags: approval-mozilla-aurora+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
RE "checkin-needed" -- does this want to land on m-c, too, or just aurora/beta?
(Assignee)

Comment 16

6 years ago
(In reply to comment #15)
> RE "checkin-needed" -- does this want to land on m-c, too, or just
> aurora/beta?

Please land on m-c as well.  Thanks!
http://hg.mozilla.org/mozilla-central/rev/d0071580fb55
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 7
http://hg.mozilla.org/releases/mozilla-beta/rev/3410d77f65aa
status-firefox5: --- → fixed
Keywords: checkin-needed
http://hg.mozilla.org/releases/mozilla-aurora/rev/5b19bad76854
status-firefox6: --- → fixed
Mozilla/5.0 (Windows NT 5.1; rv:6.0a2) Gecko/20110525 Firefox/6.0a2

Checked it on WinXP, Win 7, Mac OSX, Ubuntu.
Using the steps to reproduce from Comment 0, I was able to cut, copy, paste, undo, selectAll but not able to redo (ctrl+y/cmd+y) any of the actions. 

Reopening issue.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
They're different on unix and mac/win. We're unfortunately supporting unix only atm.

> #ifdef XP_UNIX
>     <key id="key_redo" key="&undoCmd.key;" modifiers="accel,shift"/>
> #else
>     <key id="key_redo" key="&redoCmd.key;" modifiers="accel"/>
> #endif
Based on comment 21, I think this can be re-resolved and a new one open specific to the "redo" keybinding. Tim?
(Assignee)

Comment 23

6 years ago
Filed bug 660017
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
(In reply to comment #10)
> (In reply to comment #9)
> > is this the bug that would cover not being able to paste anything into the
> > find-field of panorama or would that require a new bug ?
> 
> I think we can handle this here as the patch will very likely fix this, too.

The context menu of the findbar is still missing, new bug blocking this one or Bug 653099 ?
(Assignee)

Comment 25

6 years ago
Context menu is a different topic.  It should block bug 653099 and bug 590251
bugspam
Blocks: 660175
No longer blocks: 653099

Comment 27

6 years ago
Verified on Ubuntu 11.04 x86, Mac OS X 10.6, Win 7 x86 and WinXP.

With the exception of CTRL+Y (redo) which has it's  own bug 660017, keyboard shortcuts work within Panorama. Setting status to Verified Fixed.
Status: RESOLVED → VERIFIED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.