654612 - Editor performance details does not update

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect)

Description

[krupa raj[:krupa]]

Attachment: screenshot

steps to reproduce:
1. I have reviewed 3 add-ons in the last two days from the account "kr raj". See https://addons-next.allizom.org/en-US/editors/reviewlog
2. Load https://addons-next.allizom.org/en-US/editors/performance


expected behavior:
My reviews section lists '3'

observed behavior:
My reviews section shows '0'. See screenshot

Comment 1

[Wil Clouser [:clouserw]]

what's the news on this?

Comment 2

[Gregory Koberger (:gkoberger)]

Currently testing my patch to make sure it works.

Comment 3

[Gregory Koberger (:gkoberger)]

https://github.com/jbalogh/zamboni/commit/3d46c6cf111d4108f61a8da193e162e96d43d0a4

On next, the numbers will be slightly off from preview, since andym caught a small bug after I had landed it.

Comment 4

[krupa raj[:krupa]]

The graph doesn't update when I review add-ons.

Compare the info @ https://addons.allizom.org/en-US/editors/reviewlog to https://addons.allizom.org/en-US/editors/performance

There are 10+ add-on reviews in May. Performance page just shows 2

Reopening..

Comment 5

[krupa raj[:krupa]]

So, reviews done from my admin account are not getting counted.

Comment 6

[Gregory Koberger (:gkoberger)]

https://github.com/jbalogh/zamboni/commit/0137d

Comment 7

[krupa raj[:krupa]]

We update the review count when the editor chooses 'Request more information' and 'Request super-review' options. This means that the same add-on will be counted multiple times. Is that okay?

Comment 8

[Gregory Koberger (:gkoberger)]

I asked Jorge, and he said that's the way it should work.  If we want to change it, you can file a bug to group it by add-on ID, so each add-on only shows up once.

Comment 9

[krupa raj[:krupa]]

If jorgev is happy, I'm happy.

verified fixed @ https://addons.allizom.org/en-US/editors/performance

Checked with accounts with 'editor' and 'admin' prevs. verified that all editor actions are logged for all review queues.