654669 - [collector] Cannot remove an add-on from a collection with "Publish to" dropdown

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Collector Extension, defect, P2)

Description

[klint]

User-Agent:       Mozilla/5.0 (Windows NT 5.1; rv:2.0.1) Gecko/20100101 Firefox/4.0.1
Build Identifier: Firefox 4.01 with Add On Collector 2.0.1

An addon which is in a collection I'm subscribing to cannot be removed from that collection using the "publish to" dropdown list provided by the Addon Collector addon.

Reproducible: Always

Steps to Reproduce:
1. Subscribe to a collection with addons inside
2. Refresh collection data in the Addon Collector
3. Go to any addon in that collection (either in the Collections pane, or in the Addons pane, in any pane...)
4. click on the "Publish to" dropdown
5. Check that the addon entry is checked for the chosen collection
6. Try to remove the addon from the collection by clicking on that checked entry in the dropdown

Actual Results:  
Nothing happens: the addon is not removed from the collection

Expected Results:  
The addon should be removed from the collection

Comment 1

[Brian King [:kinger]]

bandwagon(DEBUG): In BandwagonExtensionsOverlayController.doRemoveFromCollection() with collection = 'Automagical (https://addons.mozilla.org/en-US/firefox/api/1.3/sharing//collections/a7294b6c-f9f1-6d42-e594-1aee2fca940a/)' and extension: name = 'Ant Video Downloader', guid = '[e-mail]'

Error: BandwagonExtensionsOverlayController.stringBundle is null
Source File: chrome://bandwagon/content/ui/overlays/extensionsOverlayController.js
Line: 179

Comment 2

[Brian King [:kinger]]

Attachment: WIP debug patch

The basic gist here is that the Publish menu population relies on selection of items in a list which is not always reliable. It causes this and other bugs.

We are not rebuilding the menu on selection. A full audit is required for this code (stuffPublishUI and related).

Comment 3

[David McNamara]

Publish button overhaul landed in r90147

This should be fixed now.