654752 - Make runtests.py work out of the box with Fennec

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Benjamin Stover (:stechz)]

runtests.py currently needs a binary passed to it in order to work with Fennec. blassey suggests that we work like Firefox, where fennec is a run-mozilla.sh script and fennec-bin is the actual binary.

Comment 1

[Benjamin Stover (:stechz)]

Attachment: Make runtests.py work out of the box with Fennec

Comment 2

[Benjamin Stover (:stechz)]

Comment on attachment 530080 [details] [diff] [review]
Make runtests.py work out of the box with Fennec

Hey Joel,

I'd love your feedback on this. Will this affect our automation at all?

Comment 3

[Benjamin Stover (:stechz)]

Attachment: Make runtests.py work out of the box with Fennec

Comment 4

[Benjamin Stover (:stechz)]

Mark's suggestion was to change automation to look for the proper binary name.

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 530101 [details] [diff] [review]
Make runtests.py work out of the box with Fennec

Review of attachment 530101 [details] [diff] [review]:

this will work for android and maemo automation since we specifically override the binary name (i.e. org.mozilla.fennec and <custompath>/fennec).

A change like this I would run on try server even though this is very specfic to mobile.

Comment 6

[cmtalbert]

(In reply to comment #3)
> Created attachment 530101 [details] [diff] [review] [review]
> Make runtests.py work out of the box with Fennec

So, if I understand this properly, what we'll have at the end of a build with these changes is two identical files: fennec-bin and fennec both of which are binary executables?  I just don't see where you are creating the fennec shell script in this patch.  Is that done automatically?

I'm building it all right now, will probably be able to answer my own questions once the build finishes.

In general, as long as the new 'fennec' executable script can take all the parameters of the old 'fennec' binary executable you should be just fine.  The release engineering automation does depend on calling 'fennec' for desktop fennec testing, so as long as it exists and passes the parameters through, you should be good to go.

So tentative r+, I'll poke back once I see what my build outputs.

Comment 7

[Benjamin Stover (:stechz)]

Hey Clint,

Sorry to confuse you. The strategy changed from doing what Firefox does to changing the automation to recognize Fennec because we found the script to be in bad taste. :)

My try run is here: http://tbpl.mozilla.org/?tree=Try&rev=782f8e6a7721

Comment 8

[cmtalbert]

Comment on attachment 530101 [details] [diff] [review]
Make runtests.py work out of the box with Fennec

the try run and the builds look good to me.  Also I don't think that fennec desktop stuff is running right now in production so likelihood of messing with that code is low.

Comment 9

[Benjamin Stover (:stechz)]

Pushed http://hg.mozilla.org/mozilla-central/rev/ffe31dc2d27f

Comment 10

[(not currently active) Ted Mielczarek]

FWIW, bug 557027 is where I ditched the 'fennec' script (and turned fennec-bin into fennec), enabled for our Tinderbox builds in bug 557027.

Comment 11

[Matt Brubeck (:mbrubeck)]

Backed out because something that landed with this caused a new orange (Win debug Moth tabview/browser_tabview_bug597248.js):
http://hg.mozilla.org/mozilla-central/rev/eaaa24ff93a0

Comment 12

[Matt Brubeck (:mbrubeck)]

re-landed: http://hg.mozilla.org/mozilla-central/rev/59594568f152

Comment 13

[Andreea Pod]

Verified fixed in Tinderbox http://tbpl.mozilla.org/?tree=Mobile&noignore=1