Closed
Bug 654798
Opened 15 years ago
Closed 15 years ago
Fennec browser chrome tests install to the wrong place
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 6
People
(Reporter: stechz, Assigned: stechz)
References
Details
Attachments
(1 file, 1 obsolete file)
|
13.76 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
They are installed to mobile/chrome/ instead of mobile/chrome/tests.
|
Assignee | |
Comment 1•15 years ago
|
||
Attachment #530114 -
Flags: review?(mark.finkle)
|
||
Comment 2•15 years ago
|
||
Comment on attachment 530114 [details] [diff] [review]
Fennec browser chrome tests install to the wrong place
let's get Joel's opinion on whether this will somehow break maemo or android packaging of tests.
Attachment #530114 -
Flags: review?(mark.finkle)
Attachment #530114 -
Flags: review?(jmaher)
Attachment #530114 -
Flags: review+
|
||
Comment 3•15 years ago
|
||
Comment on attachment 530114 [details] [diff] [review]
Fennec browser chrome tests install to the wrong place
Review of attachment 530114 [details] [diff] [review]:
this should work just fine on android/maemo. We run the tests with '--test-path=mobile', so it doesn't matter what the subdirectories look like.
Good catch!
Attachment #530114 -
Flags: review?(jmaher) → review+
|
|
Assignee | |
Comment 4•15 years ago
|
||
Fixed more hard-coded paths, removing them where I could.
Attachment #530124 -
Flags: review?(jmaher)
|
|
Assignee | |
Updated•15 years ago
|
Attachment #530114 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•15 years ago
|
Assignee: nobody → ben
|
|
||
Comment 5•15 years ago
|
||
Comment on attachment 530124 [details] [diff] [review]
Fennec browser chrome tests install to the wrong place
Review of attachment 530124 [details] [diff] [review]:
thanks for the cleanup!
Attachment #530124 -
Flags: review?(jmaher) → review+
|
|
Assignee | |
Comment 6•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Updated•15 years ago
|
Target Milestone: --- → Firefox 6
|
|
||
Comment 7•15 years ago
|
||
Backed out because something that landed with this caused a new orange (Win debug Moth tabview/browser_tabview_bug597248.js):
http://hg.mozilla.org/mozilla-central/rev/eaaa24ff93a0
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
||
Comment 8•15 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Resolution: --- → FIXED
|
|
||
Comment 9•14 years ago
|
||
Can someone please verify this bug or provide some steps to reproduce?
|
|
||
Comment 10•14 years ago
|
||
Verified This was just a code movement no tests sitting in http://hg.mozilla.org/mozilla-central/file/f584467626df/mobile/chrome atm.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•