[stage] Browsing marks - unable to 'view first' mark

VERIFIED FIXED in 1.0

Status

Websites
markup.mozilla.org
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: mbrandt, Assigned: Adam Miller)

Tracking

unspecified

Details

(Whiteboard: [stage], URL)

(Reporter)

Description

7 years ago
Mark Browsing pane: Clicking the 'view first' renders a page empty of marks.

http://screencast.com/t/NxHo3epQ2Xt

Steps to reproduce:
1. go to https://markup.allizom.org/en-US/#/linear/
2. click 'view first' in the Mark Browsing panel

Actual:
A page devoid of marks is displayed. Note the same behavior also occurs if you:
1. click 'view last' mark (the last mark is properly displayed)
2. click 'view first' mark

Expected:
The first mark should be shown.
Assignee: nobody → jbresnik
(Assignee)

Comment 1

7 years ago
The first mark, which has a reference of 5v27, has no data in it, neither do any of the 19 marks following it. These marks should be removed, along with any other marks that have no data in them. 

The javascript has been improved to prevent blank marks from being submitted, as well as handling cases where blank marks are returned, HOWEVER, it can't currently handle this case where all of the data it gets is blank marks. 

I'm going to add a default mark to be rendered in cases where the mark's data is blank or malformed. Then we should be able to flag any bad marks, and have them deleted through the admin.
How do we delete/remove the marks? They aren't available to remove from the admin panel, so what do you suggest?

Updated

7 years ago
Assignee: jbresnik → adam
(Assignee)

Comment 3

7 years ago
once I commit my fix, you will be able to flag and remove them. They'll be showing up as question marks in the visualization.
(Reporter)

Comment 5

7 years ago
Laura, when you get a moment can VERIFY the patch Adam submitted?
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
It works, thanks!
Status: RESOLVED → VERIFIED
Sorry, wrong bug--let me check.
Status: VERIFIED → RESOLVED
Last Resolved: 7 years ago7 years ago
Verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.