Closed Bug 654904 Opened 9 years ago Closed 9 years ago
Link tap highlight does not disappear after panning ends
Steps to reproduce: 1. Open http://news.ycombinator.com/ and zoom in. 2. Press on a link, and... 3. ...without lifting your finger, drag to pan the page. 4. Stop panning. Expected results: Tap highlight disappears after a moment. Actual results: Tap highlight remains, even after panning stops. Similar but not a duplicate of bug 625832. That bug is about the tap highlight not disappearing immediately at the *start* of panning. However, until a few days ago, the tap highlight at least disappeared at the *end* of panning. Now it doesn't even do that. I suspect this more recent regression is related to touch events (bug 544614).
This was a regression from my patch in bug 653009, which removed the PanBegin listener in ContentTouchHandler. This patch adds a PanBegin listener. But instead of cancelling the tap highlight *and* discarding pending messages (which broke MouseMove messaging, which is why it was removed before), now it will *just* cancel the tap highlight.
Attachment #530224 - Flags: review?(wjohnston)
Comment on attachment 530224 [details] [diff] [review] patch Review of attachment 530224 [details] [diff] [review]: Thanks
Attachment #530224 - Flags: review?(wjohnston) → review+
does it work for scrollable divs/iframes?
Backed out because something that landed with this caused a new orange (Win debug Moth tabview/browser_tabview_bug597248.js): http://hg.mozilla.org/mozilla-central/rev/eaaa24ff93a0 This can probably land again once we figure out the cause of the test failures.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Followup re-landed: http://hg.mozilla.org/mozilla-central/rev/633511f3d20b
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
Verified fixed on build: Mozilla /5.0 (Android;Linux armv7l;rv:6.0a1) Gecko/20110508 Firefox/6.0a1 Fennec/6.0a1 Device: LG Optimus 2X (Android 2.2)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.