The default bug view has changed. See this FAQ.

Link tap highlight does not disappear after panning ends

VERIFIED FIXED in Firefox 6

Status

Fennec Graveyard
General
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: mbrubeck, Assigned: mbrubeck)

Tracking

({regression})

Trunk
Firefox 6
regression

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Steps to reproduce:
1. Open http://news.ycombinator.com/ and zoom in.
2. Press on a link, and...
3. ...without lifting your finger, drag to pan the page.
4. Stop panning.

Expected results: Tap highlight disappears after a moment.
Actual results: Tap highlight remains, even after panning stops.

Similar but not a duplicate of bug 625832.  That bug is about the tap highlight not disappearing immediately at the *start* of panning.  However, until a few days ago, the tap highlight at least disappeared at the *end* of panning.  Now it doesn't even do that.  I suspect this more recent regression is related to touch events (bug 544614).
(Assignee)

Comment 1

6 years ago
Created attachment 530224 [details] [diff] [review]
patch

This was a regression from my patch in bug 653009, which removed the PanBegin listener in ContentTouchHandler.

This patch adds a PanBegin listener.  But instead of cancelling the tap highlight *and* discarding pending messages (which broke MouseMove messaging, which is why it was removed before), now it will *just* cancel the tap highlight.
Attachment #530224 - Flags: review?(wjohnston)
tracking-fennec: ? → 6+
Comment on attachment 530224 [details] [diff] [review]
patch

Review of attachment 530224 [details] [diff] [review]:

Thanks
Attachment #530224 - Flags: review?(wjohnston) → review+
(Assignee)

Comment 3

6 years ago
http://hg.mozilla.org/mozilla-central/rev/6a2724d755f3
Blocks: 653009
Status: NEW → RESOLVED
Last Resolved: 6 years ago
status-firefox5: --- → unaffected
Keywords: regressionwindow-wanted
Resolution: --- → FIXED
Target Milestone: --- → Firefox 6
does it work for scrollable divs/iframes?
(Assignee)

Comment 5

6 years ago
Backed out because something that landed with this caused a new orange (Win debug Moth tabview/browser_tabview_bug597248.js):
http://hg.mozilla.org/mozilla-central/rev/eaaa24ff93a0

This can probably land again once we figure out the cause of the test failures.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 6

6 years ago
Followup re-landed: http://hg.mozilla.org/mozilla-central/rev/633511f3d20b
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED

Comment 7

6 years ago
Verified fixed on build: Mozilla /5.0 (Android;Linux armv7l;rv:6.0a1) Gecko/20110508 Firefox/6.0a1 Fennec/6.0a1 
Device: LG Optimus 2X (Android 2.2)
Status: RESOLVED → VERIFIED
status-firefox6: --- → fixed
You need to log in before you can comment on or make changes to this bug.