First tab in group has black thumbnail after "Undo close group" is used

VERIFIED FIXED in Firefox 6

Status

Firefox Graveyard
Panorama
VERIFIED FIXED
6 years ago
a year ago

People

(Reporter: George Carstoiu, Assigned: ttaubert)

Tracking

Trunk
Firefox 6
Dependency tree / graph
Bug Flags:
in-testsuite +

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

6 years ago
Created attachment 530255 [details]
Screenshot 1

Mozilla/5.0 (Windows NT 6.1; rv:6.0a1) Gecko/20110504 Firefox/6.0a1

After pressing the Undo close tab option, the first thumbnail in the group becomes black - see Screenshot 1.

Reproducible: always

Steps to reproduce:
1. Open a few tabs
2. Go into Panorama
3. Close the group that contains all the tabs
4. Press Undo close tab

Actual results:
 - the first thumbnail in the group is black

Expected results:
 - all tabs are displayed normally

This issue may be related to bug 624692.
(Reporter)

Updated

6 years ago
tracking-firefox6: --- → ?
Target Milestone: --- → Firefox 6
(Assignee)

Updated

6 years ago
Blocks: 653099
Hardware: x86 → All
(Assignee)

Updated

6 years ago
Assignee: nobody → tim.taubert
Blocks: 624692
Status: NEW → ASSIGNED
(Assignee)

Comment 1

6 years ago
Created attachment 530616 [details] [diff] [review]
patch v1
Attachment #530616 - Flags: feedback?(raymond)
Comment on attachment 530616 [details] [diff] [review]
patch v1

Tried the patch.  It works!
Attachment #530616 - Flags: feedback?(raymond) → feedback+

Comment 3

6 years ago
tracking-firefox flags aren't for suggesting something is important. If you think it's important, work with the leads of that module to get it prioritized.
tracking-firefox6: ? → -
(Assignee)

Comment 4

6 years ago
Comment on attachment 530616 [details] [diff] [review]
patch v1

Passed try:

http://tbpl.mozilla.org/?tree=Try&pusher=tim.taubert@gmx.de&rev=0b0c5795db4f
(Assignee)

Comment 5

6 years ago
Comment on attachment 530616 [details] [diff] [review]
patch v1

I hope you are willing to take the review for this, Ehsan :)

The main fix here is to call UI.setActive() after all tabItems are shown again. So they're not arranged when hidden. The second test case covers bug 624692 that is fixed by this patch, too.
Attachment #530616 - Flags: review?(ehsan)
Attachment #530616 - Flags: review?(ehsan) → review+
(Assignee)

Comment 6

6 years ago
Created attachment 531623 [details] [diff] [review]
patch for checkin
Attachment #530616 - Attachment is obsolete: true
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
http://hg.mozilla.org/projects/cedar/rev/32fc5f49b989
Keywords: checkin-needed
Whiteboard: fixed-in-cedar
Pushed:
http://hg.mozilla.org/mozilla-central/rev/32fc5f49b989
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: fixed-in-cedar
(Reporter)

Comment 9

6 years ago
Mozilla/5.0 (X11; Linux i686; rv:7.0a1) Gecko/20110620 Firefox/7.0a1

Verified on Ubuntu 11.04 x86, Mac OS X 10.6, WinXP, Win 7 x86 using the steps from Comment 0.

Setting status to Verified Fixed.
Status: RESOLVED → VERIFIED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.