655029 - demo detail breaks with non-ASCII characters in title?

Status: VERIFIED FIXED

(developer.mozilla.org Graveyard :: Demo Studio / Dev Derby, defect)

Description

[Luke Crouch [:groovecoder]]

Traceback (most recent call last):

  File "/data/www/django/developer.mozilla.org/mdn/vendor/packages/Django/django/core/handlers/base.py", line 100, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/data/www/django/developer.mozilla.org/mdn/apps/demos/views.py", line 87, in detail
    'more_by': more_by

  File "/data/www/django/developer.mozilla.org/mdn/vendor/src/jingo/jingo/__init__.py", line 63, in render
    rendered = render_to_string(request, template, context)

  File "/data/www/django/developer.mozilla.org/mdn/vendor/src/jingo/jingo/__init__.py", line 84, in render_to_string
    return template.render(**get_context())

  File "/data/www/django/developer.mozilla.org/mdn/vendor/packages/jinja2/jinja2/environment.py", line 891, in render
    return self.environment.handle_exception(exc_info, True)

  File "/data/www/django/developer.mozilla.org/mdn/apps/demos/templates/demos/detail.html", line 4, in top-level template code
    {% set short_url = full_url | bitly_shorten %}

  File "/data/www/django/developer.mozilla.org/mdn/apps/demos/templates/demos/base.html", line 1, in top-level template code
    {% extends "base_compact.html" %}

  File "/data/www/django/developer.mozilla.org/mdn/templates/base_compact.html", line 1, in top-level template code
    {% extends "base.html" %}

  File "/data/www/django/developer.mozilla.org/mdn/templates/base.html", line 89, in top-level template code
    {% block content %}{% endblock %}

  File "/data/www/django/developer.mozilla.org/mdn/apps/demos/templates/demos/detail.html", line 111, in block "content"
    <li class="twitter"><a href="http://twitter.com/share?{{ urlencode({"url":short_url, "text":submission.title, "via":"mozhacks"}) }}">{{_('Share on Twitter')}}</a></li>

  File "/data/www/django/developer.mozilla.org/mdn/apps/demos/helpers.py", line 145, in urlencode
    return urllib.urlencode(args)

  File "/usr/lib/python2.6/urllib.py", line 1267, in urlencode
    v = quote_plus(str(v))

UnicodeEncodeError: 'ascii' codec can't encode character u'\xb0' in position 3: ordinal not in range(128)

Comment 1

[Luke Crouch [:groovecoder]]

non-ascii characters are properly encoded to utf-8 for the share links to remove the error. e.g., https://developer-stage9.mozilla.org/en-US/demos/detail/foo-foo-360

Comment 2

[raymond [:retornam] (inactive)]

qa-verified-stage  https://developer-stage9.mozilla.org/en-US/demos/detail/foo-foo-360  by entering 猫はさせている

Comment 3

[raymond [:retornam] (inactive)]

verified fixed https://developer.mozilla.org/en-US/demos/detail/marblerun