Closed Bug 655042 Opened 9 years ago Closed 9 years ago

Missing prtypes header in jscpucfg causes cross-builds to fail.

Categories

(Core :: JavaScript Engine, defect)

Other Branch
ARM
Android
defect
Not set
blocker

Tracking

()

RESOLVED FIXED

People

(Reporter: jbramley, Assigned: jbramley)

Details

Attachments

(1 file)

It looks like a merge took out the prtypes header from jscpucfg.cpp. This header was responsible for defining IS_LITTLE_ENDIAN for cross-builds, and so the ARM Android tree burns in Tinderbox.

The offending merge is here: http://hg.mozilla.org/projects/jaegermonkey/rev/c6120a2f9a9b
This patch simply replaces the #include. There might be some reason why it shouldn't be there, but I'm not sure.

Unfortunately, this won't make everything green again because there's some other bug further in the build process. However, it does seem to clear the endianness error.
Attachment #530341 - Flags: review?(pbiggar)
Comment on attachment 530341 [details] [diff] [review]
Replace the prtypes inclusion.

Review of attachment 530341 [details] [diff] [review]:

The fix looks right to me, but best check with bhackett in case there was a reason he removed it.
Attachment #530341 - Flags: review?(pbiggar)
Attachment #530341 - Flags: review?(bhackett1024)
Attachment #530341 - Flags: feedback+
Comment on attachment 530341 [details] [diff] [review]
Replace the prtypes inclusion.

I think I had a build problem and removing this fixed it.  May have just been something stale, if the problem comes back can find a way to fix it without breaking ARM.
Attachment #530341 - Flags: review?(bhackett1024) → review+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.