Closed
Bug 655115
Opened 14 years ago
Closed 14 years ago
Use addon validator to detect and update addons with binary components
Categories
(addons.mozilla.org Graveyard :: Developer Pages, defect, P3)
addons.mozilla.org Graveyard
Developer Pages
Tracking
(Not tracked)
RESOLVED
FIXED
6.0.10
People
(Reporter: kumar, Assigned: andy+bugzilla)
Details
To help with Firefox 5 compatibility, run a one time script that flags all binary addons. The new metadata feature in the addon validation can be used to discover which addons have binary components. See bug 649862 for details.
Comment 1•14 years ago
|
||
We should unflag all existing binary add-ons as part of this too.
Updated•14 years ago
|
Assignee: nobody → amckay
Priority: -- → P3
Target Milestone: --- → 6.0.10
Assignee | ||
Comment 2•14 years ago
|
||
Presumably I just pass the most recent file (irregardless of platform) through the validator?
Assignee | ||
Comment 3•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 5•14 years ago
|
||
(In reply to comment #1)
> We should unflag all existing binary add-ons as part of this too.
What should we do in this scenario? :
1. addon is already flagged as binary
2. the validator runs but some unexpected exception is raised like a javascript syntax error, non-ascii text (Unicode error), or the xpi file cannot be found.
Should the addon's binary flag still be removed? In this scenario we have no validator output to tell us if it's binary or not. This will [hopefully] be a very rare case but since we're running the script on *all* addons it is bound to happen.
My opinion is that we do not update these addons and just check the log to inspect the exceptions and decide what to do then.
Comment 6•14 years ago
|
||
That's fine. Though if we can't find the xpi file it seems like there are other problems to be addressed.
Assignee | ||
Comment 7•14 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
Updated•9 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•