Redirect from firefox.com/download 302s to a 404 :-(

VERIFIED FIXED in 3.2

Status

P1
major
VERIFIED FIXED
8 years ago
7 years ago

People

(Reporter: stephend, Assigned: rik)

Tracking

unspecified

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
Created attachment 530496 [details]
Screenshot

[19:15:22.430] GET http://www.firefox.com/download [HTTP/1.1 302 Found 113ms]
[19:15:22.547] GET http://www.mozilla.com/firefox/download [HTTP/1.1 302 Found 186ms]
[19:15:22.744] GET http://www.mozilla.com/en-US/firefox/download [HTTP/1.1 404 Not Found 192ms]

#fail :-(

Raymond, when/if this gets fixed, please add a redirect test for it, thanks (doesn't have to use Selenium).
Flags: in-testsuite?
(Reporter)

Comment 1

8 years ago
Should *probably* go to http://www.mozilla.com/en-US/products/download.html?product=firefox-4.0.1&os=osx&lang=en-US (with the appropriate values for your platform and the latest build), but I don't know for sure.
As far as I know, this never worked. Are you calling this a regression or just a feature request?

Side note: firefox.com/<WHATEVER> does a 302 to www.mozilla.com/firefox/<WHATEVER>. There isn't a specific redirect for /download.
(Reporter)

Comment 3

8 years ago
Was surprised this didn't work -- not calling it a regression, no.

Comment 4

8 years ago
So what should the fix be here exactly? Still not 100% clear to me.
(Reporter)

Comment 5

8 years ago
(In reply to comment #4)
> So what should the fix be here exactly? Still not 100% clear to me.

Was hoping you or someone else responsible for Mozilla.com could provide direction; I'm not going to prescribe a fix, but I did make a suggestion in comment 1.  Just think we shouldn't 302 twice over to a 404 -- we should do something more meaningful, and if it's not hard to implement, comment 1, makes sense to me, unless we lose metrics from a lack of a Download Now click?

Comment 6

8 years ago
(In reply to comment #5)
> (In reply to comment #4)
> > So what should the fix be here exactly? Still not 100% clear to me.
> 
> Was hoping you or someone else responsible for Mozilla.com could provide
> direction; I'm not going to prescribe a fix, but I did make a suggestion in
> comment 1.  Just think we shouldn't 302 twice over to a 404 -- we should do
> something more meaningful, and if it's not hard to implement, comment 1,
> makes sense to me, unless we lose metrics from a lack of a Download Now
> click?

James - any thoughts here?
Target Milestone: --- → 2.5
> James - any thoughts here?

I think it's a great idea, but off the top of my head it's a bit complicated. The download URLs are generated via javascript when it generates the download button. All the product/platform/etc data is process then.

We'll have to create a php file at /download which generates this info and redirect them appropriately. The "API" for generating this data is pretty crufty though, so it'll take some time to make sure it's generating correct URLs for everyone.

Anthony might know more about this. I'm willing to do this at some point though.
(Assignee)

Comment 8

8 years ago
Currently firefox.com is a naive system as described by Reed (just some rules in Apache AFAICT). I think we should make it a bit smarter. As an example, Pascal and I often talked about doing language detection on firefox.com to save one redirection.

And with a smarter system, I think we should redirect all firefox.com/<WHATEVER> to mozilla.com homepage except some special URLs that we link.

Or redirect to mozilla.com/<WHATEVER> if we know it's not a 404 and to mozilla.com homepage if we find a 404.

About redirecting to the download page, I don't think it's a good idea. When you type firefox.com/download, you don't expect an automatic download to be triggered.
(Reporter)

Comment 9

8 years ago
What about just sending them to http://www.mozilla.com/firefox/all.html?

Updated

8 years ago
Target Milestone: 2.5 → 2.6

Updated

8 years ago
Target Milestone: 2.6 → 2.7
Target Milestone: 2.7 → 2.8

Updated

8 years ago
Target Milestone: 2.8 → 2.9

Updated

8 years ago
Target Milestone: 2.9 → 2.10

Comment 10

8 years ago
James & Anthony,

Can you rally with a reply to Stephen and get this into our final release this quarter - it matches up nicely with the new 404 page, etc.

Thanks!
CB

Updated

8 years ago
Assignee: nobody → jlong

Updated

8 years ago
Priority: -- → P1
(Assignee)

Comment 11

8 years ago
Stephen: I'd rather redirect to http://www.mozilla.com. It's easier to download from there than from all.html, you don't have to find your language. What do you think?

Chrissie: We should assign this to IT once we decide where to redirect. That way they set up the redirect on firefox.com.
(Reporter)

Comment 12

8 years ago
(In reply to comment #11)
> Stephen: I'd rather redirect to http://www.mozilla.com. It's easier to
> download from there than from all.html, you don't have to find your
> language. What do you think?
> 
> Chrissie: We should assign this to IT once we decide where to redirect. That
> way they set up the redirect on firefox.com.

Sounds fine to me.

Comment 13

8 years ago
Ok, assigning to Cory to assign to his team, thank you all :)
Assignee: jlong → cshields

Comment 14

8 years ago
Hey Cory,

Checking in to see if you might be able to have one of your team members help us out with this bug?

LMK,
CB

Updated

8 years ago
Target Milestone: 2.10 → 3.0

Updated

8 years ago
Target Milestone: 3.0 → 3.1

Updated

8 years ago
Assignee: cshields → anthony

Updated

8 years ago
Target Milestone: 3.1 → 3.2
(Assignee)

Comment 15

8 years ago
Committed r92695 on trunk.
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Assignee)

Updated

8 years ago
Keywords: qawanted
(Assignee)

Comment 16

8 years ago
Pushed to stage/production with r92701.
(Reporter)

Comment 17

8 years ago
[10:29:20.815] GET http://www-trunk.stage.mozilla.com/en-US/firefox/download [HTTP/1.1 301 Moved Permanently 9ms]
[10:29:20.844] GET http://www-trunk.stage.mozilla.com/ [HTTP/1.1 302 Found 10ms]
[10:29:20.867] GET https://www-trunk.stage.mozilla.com/en-US/firefox/new/ [HTTP/1.1 200 OK 55ms]

qa-verified-trunk
(Reporter)

Comment 18

8 years ago
Verified FIXED on prod:

[10:33:06.950] GET http://www.firefox.com/download [HTTP/1.1 302 Found 6ms]
[10:33:06.977] GET http://www.mozilla.com/ [HTTP/1.1 302 Found 13ms]
Status: RESOLVED → VERIFIED
Keywords: qawanted
Component: www.mozilla.org/firefox → www.mozilla.org
Product: Websites → Websites
Component: www.mozilla.org → General
Product: Websites → www.mozilla.org
You need to log in before you can comment on or make changes to this bug.