655193 - Redirect from firefox.com/download 302s to a 404 :-(

Status: VERIFIED FIXED

(www.mozilla.org :: General, defect, P1)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot

[19:15:22.430] GET http://www.firefox.com/download [HTTP/1.1 302 Found 113ms]
[19:15:22.547] GET http://www.mozilla.com/firefox/download [HTTP/1.1 302 Found 186ms]
[19:15:22.744] GET http://www.mozilla.com/en-US/firefox/download [HTTP/1.1 404 Not Found 192ms]

#fail :-(

Raymond, when/if this gets fixed, please add a redirect test for it, thanks (doesn't have to use Selenium).

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Should *probably* go to http://www.mozilla.com/en-US/products/download.html?product=firefox-4.0.1&os=osx&lang=en-US (with the appropriate values for your platform and the latest build), but I don't know for sure.

Comment 2

[Reed Loden [:reed]]

As far as I know, this never worked. Are you calling this a regression or just a feature request?

Side note: firefox.com/<WHATEVER> does a 302 to www.mozilla.com/firefox/<WHATEVER>. There isn't a specific redirect for /download.

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Was surprised this didn't work -- not calling it a regression, no.

Comment 4

[John Slater]

So what should the fix be here exactly? Still not 100% clear to me.

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #4)
> So what should the fix be here exactly? Still not 100% clear to me.

Was hoping you or someone else responsible for Mozilla.com could provide direction; I'm not going to prescribe a fix, but I did make a suggestion in comment 1.  Just think we shouldn't 302 twice over to a 404 -- we should do something more meaningful, and if it's not hard to implement, comment 1, makes sense to me, unless we lose metrics from a lack of a Download Now click?

Comment 6

[Laura Forrest]

(In reply to comment #5)
> (In reply to comment #4)
> > So what should the fix be here exactly? Still not 100% clear to me.
> 
> Was hoping you or someone else responsible for Mozilla.com could provide
> direction; I'm not going to prescribe a fix, but I did make a suggestion in
> comment 1.  Just think we shouldn't 302 twice over to a 404 -- we should do
> something more meaningful, and if it's not hard to implement, comment 1,
> makes sense to me, unless we lose metrics from a lack of a Download Now
> click?

James - any thoughts here?

Comment 7

[James Long (:jlongster)]

> James - any thoughts here?

I think it's a great idea, but off the top of my head it's a bit complicated. The download URLs are generated via javascript when it generates the download button. All the product/platform/etc data is process then.

We'll have to create a php file at /download which generates this info and redirect them appropriately. The "API" for generating this data is pretty crufty though, so it'll take some time to make sure it's generating correct URLs for everyone.

Anthony might know more about this. I'm willing to do this at some point though.

Comment 8

[Anthony Ricaud (:rik)]

Currently firefox.com is a naive system as described by Reed (just some rules in Apache AFAICT). I think we should make it a bit smarter. As an example, Pascal and I often talked about doing language detection on firefox.com to save one redirection.

And with a smarter system, I think we should redirect all firefox.com/<WHATEVER> to mozilla.com homepage except some special URLs that we link.

Or redirect to mozilla.com/<WHATEVER> if we know it's not a 404 and to mozilla.com homepage if we find a 404.

About redirecting to the download page, I don't think it's a good idea. When you type firefox.com/download, you don't expect an automatic download to be triggered.

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

What about just sending them to http://www.mozilla.com/firefox/all.html?

Comment 10

[mcbmoz]

James & Anthony,

Can you rally with a reply to Stephen and get this into our final release this quarter - it matches up nicely with the new 404 page, etc.

Thanks!
CB

Comment 11

[Anthony Ricaud (:rik)]

Stephen: I'd rather redirect to http://www.mozilla.com. It's easier to download from there than from all.html, you don't have to find your language. What do you think?

Chrissie: We should assign this to IT once we decide where to redirect. That way they set up the redirect on firefox.com.

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #11)
> Stephen: I'd rather redirect to http://www.mozilla.com. It's easier to
> download from there than from all.html, you don't have to find your
> language. What do you think?
> 
> Chrissie: We should assign this to IT once we decide where to redirect. That
> way they set up the redirect on firefox.com.

Sounds fine to me.

Comment 13

[mcbmoz]

Ok, assigning to Cory to assign to his team, thank you all :)

Comment 14

[mcbmoz]

Hey Cory,

Checking in to see if you might be able to have one of your team members help us out with this bug?

LMK,
CB

Comment 15

[Anthony Ricaud (:rik)]

Committed r92695 on trunk.

Comment 16

[Anthony Ricaud (:rik)]

Pushed to stage/production with r92701.

Comment 17

[Stephen Donner [:stephend] Not actively reading bugmail]

[10:29:20.815] GET http://www-trunk.stage.mozilla.com/en-US/firefox/download [HTTP/1.1 301 Moved Permanently 9ms]
[10:29:20.844] GET http://www-trunk.stage.mozilla.com/ [HTTP/1.1 302 Found 10ms]
[10:29:20.867] GET https://www-trunk.stage.mozilla.com/en-US/firefox/new/ [HTTP/1.1 200 OK 55ms]

qa-verified-trunk

Comment 18

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on prod:

[10:33:06.950] GET http://www.firefox.com/download [HTTP/1.1 302 Found 6ms]
[10:33:06.977] GET http://www.mozilla.com/ [HTTP/1.1 302 Found 13ms]