65523 - "View Stored Cookies" button needs a better name

Status: VERIFIED FIXED

(Core :: Networking: Cookies, defect)

Description

[vectro]

It's not at all intuitive that the "View Stored Cookies" button is how you get
to the list of cookie/server permissions. I'd suggest retitling it with
something like "Advanced cookie preferences". Or maybe have two buttons - one
that says "View Stored Cookies", and one that says "Modify server cookie
permissions" or some such thing. The two buttons would take you to different
tabs of the same dialag, but in terms of user interface, it would be much clearer.

Comment 1

[Fabian Guisset]

CC'ing mpt, prepare for the dragon breath.

Comment 2

[Stephan Niemz]

Confirming (Status NEW) for discussion, and Platform/OS All/All

Comment 3

[Matthew T (active 1999-2002)]

`Manage Cookies ...'

Comment 4

[sairuh (rarely reading bugmail)]

Manage Cookies sounds good. fewer words. :) over to morse, who owns things
Cookies-oriented.

Comment 5

[Bradley Hart]

CC:-ing Stephend, myself.

Comment 6

[Christopher Hoess (gone)]

Moving to Cookies.

Comment 7

[Jeremy M. Dolan]

Is one tab going to update the other soon? (pre-1.0)

If not, they should be seperated until this can be done, as it's extremely
confusing to users now why removing a cookie with "don't allow again" checked
doesn't seem to add it to the blockeds sites tab. Seperate dialogs would force
them to OK the view cookies dialog before viewing the site permissions one.

If that bug can be fixed, then "Manage Cookies" sounds great.

mpt, did you literally mean that space before the ellipsis? None of the others
have a space before it (and many don't even have the ellipsis). I can do a patch
for them all if that's really what we want.

Comment 8

[Vidar B. Haarr (old account)]

Attachment: "&View Stored Cookies" -> "&Manage Cookies"

this patch changes "View Stored Cookies" to "Manage Cookies", and makes the new
access-key 'M'.

I just installed Patch Maker (by gerv), and this is my first test, so I only
made this patch for fun :)

use it if you like.

Comment 9

[Stephen P. Morse]

There are many other places that "view" is used.  Go through the submenus of the 
task menu and you'll see.  So it would be inconsistent to change only one of 
them.  Therefore, as module owner of this module, I cannot approve of this 
patch.

I'm not saying that changing all the "views" to "manage" would be a good thing 
or a bad thing.  I am saying that changing some but not others would be a bad 
thing.

Comment 10

[Jeremy M. Dolan]

Morse, you forget in the dialog the button brings up, you can do much more then
view cookies. View cookies is an alright description for the first tab of the
dialog, but can we move the second tab to it's own dialog, and call it "Site
Permissions" or whatever?

This would be a workaround for the fact that currently removing a cookie with
'remember' checked doesn't add it to the list in the second tab until you 'OK'
and come back in. That's very very bad. Two seperate modals would force the OK
and not give the appearance the actions were ignored.

Comment 11

[Stephen P. Morse]

No, I didn't forget that.  And in the dialog that "view stored passwords" brings 
up you can do much more than just view the passwords -- you can delete them, 
view sites, etc.  And in the dialog that "view form data" brings up you can do 
more than just view the form data -- you can enter new data as well.

My point was that it is inconsistent to change "view" to "manage" for cookies 
and leave the others unchanged.

Comment 12

[Vidar B. Haarr (old account)]

Attachment: Changes 'View' to 'Manage' all over the place (+more)

This patch fixes all occurences of 'View' into 'Manage'.

The only thing I think I screwed up is this:

extensions/wallet/resources/locale/en-US/walletNavigatorOverlay.dtd
-<!ENTITY formshowCmd.label		"View Saved Data">
-<!ENTITY formshowCmd.accesskey 	"V"> 
+<!ENTITY formshowCmd.label		"Manage Saved Data">
+<!ENTITY formshowCmd.accesskey 	"D"> 

I changed the accesskey to 'D', when it really can be 'M'.. if someone checks
this patch in, please fix this :)

And also... this patch should obsolete patch 64308, but I don't have permission
to do so, why ? I made the patch.. is this a bugzilla bug, maybe ?

Comment 13

[Stephen P. Morse]

Looks like you got them all this time.  I no longer have any objections.

Comment 14

[Stephen P. Morse]

Comment on attachment 64475 [details] [diff] [review]
Changes 'View' to 'Manage' all over the place (+more)

r=morse

Comment 15

[Vidar B. Haarr (old account)]

CC'ing [e-mail] for sr=

Comment 16

[Alec Flett]

Comment on attachment 64475 [details] [diff] [review]
Changes 'View' to 'Manage' all over the place (+more)

sr=alecf

Comment 17

[Håkan Waara]

Reassign to Vidar so he gets the credit.

Comment 18

[Håkan Waara]

Fix checked in for Vidar.

Comment 19

[benc]

VERIFIED: this has said "cookie manager" for some time...