655249 - Array literals are toSourced rather than decompiled, creating bizarre error messages

Status: RESOLVED WORKSFORME

(Core :: JavaScript Engine, defect)

Description

[Jesse Ruderman]

Fryn brought this to my attention.

js> [].push(2).push(3)
TypeError: [2].push(2).push is not a function

js> !{}.__defineGetter__('',function(){}).__defineGetter__
TypeError: ({get '' () {}}).__defineGetter__("", function () {}) is undefined

Regression from tracemonkey changeset d4f969511664:
user:        Brian Hackett
date:        Thu Dec 30 08:07:43 2010 -0500
summary:     Don't generate INITPROP/INITELEM for singleton constant initializers, bug 577359.

I think this only happens for compile-and-go scripts, so maybe it was an expected and accepted result of the optimization in bug 577359?

Comment 1

[Frank Yan (:fryn)]

Thanks, Jesse, for filing this.

Just to clarify:

js> [].push(2).push(3)
TypeError: [2].push(2).push is not a function

Expected: TypeError: [].push(2).push is not a function

js> !{}.__defineGetter__('',function(){}).__defineGetter__
TypeError: ({get '' () {}}).__defineGetter__("", function () {}) is undefined

Expected: TypeError: ({}).__defineGetter__("", function() {}) is undefined

Comment 2

[Ryan VanderMeulen [:RyanVM]]

js> [].push(2).push(3)
typein:1: TypeError: [].push(2).push is not a function

js> !{}.__defineGetter__('',function(){}).__defineGetter__
typein:2: TypeError: {}.__defineGetter__("", function () {}) is undefined