mention sizes for icons in package.json documentation

RESOLVED FIXED

Status

Add-on SDK
Documentation
P1
normal
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: Christoph Dorn, Assigned: wbamberg)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.17) Gecko/20110420 Firefox/3.6.17
Build Identifier: 

The docs need to mention the pixel sizes of the "icon" and "icon64".

Reproducible: Always
Summary: mention sizes for icons → mention sizes for icons in package.json documentation
(Reporter)

Comment 1

7 years ago
Also, the "icon" (I presume 16x16) is used in the extension listing in the add-ons manager in the browser instead of the "icon64" (I presume 64x64).
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Mac OS X → All
Priority: -- → P2
Hardware: x86 → All
Target Milestone: --- → 1.0
(automatic reprioritization of 1.0 bugs)
Priority: P2 → P1
Target Milestone: 1.0 → 1.1
Target Milestone: 1.1 → 1.2
(Pushing all open bugs to the --- milestone for the new triage system)
Target Milestone: 1.2 → ---
(Assignee)

Comment 4

6 years ago
Sorry to take so long to get around to this.

(In reply to Christoph Dorn from comment #1)
> Also, the "icon" (I presume 16x16) is used in the extension listing in the
> add-ons manager in the browser instead of the "icon64" (I presume 64x64).

Doesn't this map on to the iconURL and icon64URL entries in the install manifest, which would make "icon" anything up to 48x48?

https://developer.mozilla.org/en/install_manifests#iconURL
Assignee: nobody → wbamberg
(Assignee)

Comment 5

6 years ago
Created attachment 569706 [details] [diff] [review]
Add note on icon sizes
Attachment #569706 - Flags: review?(warner-bugzilla)
Comment on attachment 569706 [details] [diff] [review]
Add note on icon sizes

looks good
Attachment #569706 - Flags: review?(warner-bugzilla) → review+
(Assignee)

Comment 7

6 years ago
Thanks Warner!
https://github.com/mozilla/addon-sdk/commit/05d65f8778d5e73a4e55f9cf14995f0dbb2290ee
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.