fix adb scripts to work on productions builds of android

VERIFIED FIXED

Status

Tamarin
Tools
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: Dan Schaffer, Assigned: James Sudduth)

Tracking

unspecified
ARM
Android
Bug Flags:
flashplayer-bug -

Details

(Whiteboard: code cleanup)

Attachments

(2 attachments)

Comment hidden (empty)
(Reporter)

Comment 1

7 years ago
We are using /data/app for copying the shell and abc files on android phones.  We need root access to write the shell and test files requiring developer builds of android.

The /data/local and /tmp directories can be written by any users.  By keeping all files in /data/local/tamarin we can not require root access and allow testing of production builds.
OS: Mac OS X → Android
Hardware: x86 → ARM
(Reporter)

Comment 2

7 years ago
Created attachment 530691 [details] [diff] [review]
allow acceptance tests to run on android production builds

The fix should work on our current phones and allow us to swap in htc desires or any new phone running production android.

the fix changes /data/app to /data/local/tamarin and removes the "adb root" call.  I will schedule a sandbox build.
Attachment #530691 - Flags: review?(brbaker)

Comment 3

7 years ago
Comment on attachment 530691 [details] [diff] [review]
allow acceptance tests to run on android production builds

Excellent! I was able to run the acceptance suite on my retail Droid X by simply attaching to my machine and then enabling debugging on the device, no more need for specially rooted phones!!!!
Attachment #530691 - Flags: review?(brbaker) → review+
(Reporter)

Comment 4

7 years ago
passed in the sandbox with the rooted old droids.  We should be able to swap out the old phones with new phones without updating the build system.  I'll push the patch.

Comment 5

7 years ago
changeset: 6289:1672acb907d1
user:      Dan Schaffer <dschaffe@adobe.com>
summary:   bug 655324: update android scripts to work on unrooted phones (r=brbaker)

http://hg.mozilla.org/tamarin-redux/rev/1672acb907d1

Comment 6

7 years ago
changeset: 6302:ebce4dbbd966
user:      Brent Baker <brbaker@adobe.com>
summary:   Bug 655324: fix one spot that was missed when changing avmshell to run out of /data/local/tamarin on android devices (r=brbaker)

http://hg.mozilla.org/tamarin-redux/rev/ebce4dbbd966
idle Q: Should we just kill off android_shell.sh at this point?  I was using it at one point (and using it enough that I wanted to think hard about improving it to handle use cases like multiple binaries installed at once).  But if the real one to be maintained is android_shell.py, perhaps it would be better to remove the file, so that developers don't waste time wondering which one to use or at least read in order to learn how to get the shell working.
(In reply to comment #7)
> idle Q: Should we just kill off android_shell.sh at this point?

Or alternatively, maybe put a README in platform/android saying which files the buildbot or runtests.py are relying on, and which are generally available for developers to muck with as they like.  (Or instead of a README, revise the directory structure to make these roles immediately apparent.  But a README is probably simpler overall.)

Comment 9

7 years ago
(In reply to Felix S Klock II from comment #7)
> idle Q: Should we just kill off android_shell.sh at this point?  I was using
> it at one point (and using it enough that I wanted to think hard about
> improving it to handle use cases like multiple binaries installed at once). 
> But if the real one to be maintained is android_shell.py, perhaps it would
> be better to remove the file, so that developers don't waste time wondering
> which one to use or at least read in order to learn how to get the shell
> working.

I think that the bash version of this script should be removed from the source tree. It is no longer being maintained by QE and the public documentation has been changed to reference the python version of the script.

https://developer.mozilla.org/En/Tamarin/Tamarin_Acceptance_Testing/Running_Tamarin_acceptance_tests#Testing_the_Android_Shell
Flags: flashplayer-bug-
Whiteboard: code cleanup

Comment 10

7 years ago
jsudduth: If you want to tackle the removal of the old bash script, this bug can then be closed.
(Assignee)

Comment 11

7 years ago
Will do.
Assignee: nobody → jsudduth
Status: NEW → ASSIGNED
(Assignee)

Comment 12

7 years ago
Created attachment 558378 [details] [diff] [review]
Remove the android_shell.sh script from the source tree.

This patch has passed new sandbox and performance runs.
Attachment #558378 - Flags: review?(dschaffe)
(Reporter)

Updated

7 years ago
Attachment #558378 - Flags: review?(dschaffe) → review+

Comment 13

7 years ago
changeset: 6567:a96519489b2c
user:      James Sudduth <jsudduth@adobe.com>
summary:   Bug 655324 - fix adb scripts to work on production builds of android - remove android_shell.sh from source tree (r=dschaffe)

http://hg.mozilla.org/tamarin-redux/rev/a96519489b2c
(Assignee)

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Assignee)

Updated

7 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.